Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document pod lifecycle when using EnvFrom #2754

Merged
merged 1 commit into from
Apr 5, 2017

Conversation

fraenkel
Copy link
Contributor

@fraenkel fraenkel commented Mar 9, 2017

  • Pods do not start with missing ConfigMaps or Secrets
  • Pods do not start with missing keys in ConfigMaps or Secrets
  • Pods start with invalid keys when referring to entire ConfigMaps or
    Secrets. An event documents the skipped keys from said resource.

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2017
@fraenkel
Copy link
Contributor Author

fraenkel commented Mar 9, 2017

We need to wait until kubernetes/kubernetes#42642 is merged

@fraenkel
Copy link
Contributor Author

fraenkel commented Mar 9, 2017

@pmorie Please review

@fraenkel
Copy link
Contributor Author

Code has been merged.

@chenopis chenopis added this to the 1.6 milestone Mar 22, 2017
@chenopis chenopis requested a review from pmorie March 22, 2017 01:30
@mikedanese mikedanese assigned pmorie and unassigned mikedanese Mar 28, 2017
@devin-donnelly devin-donnelly changed the base branch from release-1.6 to master March 28, 2017 19:10
@chenopis
Copy link
Contributor

chenopis commented Apr 4, 2017

@fraenkel FYI, the merge conflict is because we have been migrating the content to a new structure and moved /docs/user-guide/secrets/index.md to /docs/concepts/configuration/secret.md. If you apply your changes there, that should resolve the conflict.

@chenopis
Copy link
Contributor

chenopis commented Apr 4, 2017

@pmorie Can you take a look? Thx

Copy link
Member

@pmorie pmorie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, please escape stuff like secretKeyRef and InvalidVariableNames with backticks

- Pods do not start with missing ConfigMaps or Secrets
- Pods do not start with missing keys in ConfigMaps or Secrets
- Pods start with invalid keys when referring to entire ConfigMaps or
Secrets.  An event documents the skipped keys from said resource.
@fraenkel
Copy link
Contributor Author

fraenkel commented Apr 5, 2017

@pmorie @chenopis Back ticks added.

@chenopis
Copy link
Contributor

chenopis commented Apr 5, 2017

@fraenkel Thanks!

@chenopis chenopis merged commit ec622e1 into kubernetes:master Apr 5, 2017
nikhita added a commit to nikhita/website that referenced this pull request Mar 7, 2021
The Categories field for CRDs was documented as beta in 1.10 in kubernetes#7439
mainly because CRDs were in beta back then.

The `feature-state` tag for this section was added in kubernetes#2754, however
this section doesn't need a `feature-state` tag because the field is not
gated by any feature gate:

https://github.com/kubernetes/kubernetes/blob/90851a0fb5bbb6f02b3c22715f9f91609f8ee438/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1/types.go#L247-L251

It is now safe to remove the feature-state tag. Moreover, CRDs are now
GA so the beta state is not accurate.
ahg-g pushed a commit to ahg-g/website that referenced this pull request Mar 10, 2021
The Categories field for CRDs was documented as beta in 1.10 in kubernetes#7439
mainly because CRDs were in beta back then.

The `feature-state` tag for this section was added in kubernetes#2754, however
this section doesn't need a `feature-state` tag because the field is not
gated by any feature gate:

https://github.com/kubernetes/kubernetes/blob/90851a0fb5bbb6f02b3c22715f9f91609f8ee438/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1/types.go#L247-L251

It is now safe to remove the feature-state tag. Moreover, CRDs are now
GA so the beta state is not accurate.
s-kawamura-w664 pushed a commit to s-kawamura-w664/website that referenced this pull request Apr 22, 2021
The Categories field for CRDs was documented as beta in 1.10 in kubernetes#7439
mainly because CRDs were in beta back then.

The `feature-state` tag for this section was added in kubernetes#2754, however
this section doesn't need a `feature-state` tag because the field is not
gated by any feature gate:

https://github.com/kubernetes/kubernetes/blob/90851a0fb5bbb6f02b3c22715f9f91609f8ee438/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1/types.go#L247-L251

It is now safe to remove the feature-state tag. Moreover, CRDs are now
GA so the beta state is not accurate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants