-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document pod lifecycle when using EnvFrom #2754
Conversation
We need to wait until kubernetes/kubernetes#42642 is merged |
@pmorie Please review |
Code has been merged. |
@fraenkel FYI, the merge conflict is because we have been migrating the content to a new structure and moved |
@pmorie Can you take a look? Thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, please escape stuff like secretKeyRef
and InvalidVariableNames
with backticks
- Pods do not start with missing ConfigMaps or Secrets - Pods do not start with missing keys in ConfigMaps or Secrets - Pods start with invalid keys when referring to entire ConfigMaps or Secrets. An event documents the skipped keys from said resource.
@fraenkel Thanks! |
The Categories field for CRDs was documented as beta in 1.10 in kubernetes#7439 mainly because CRDs were in beta back then. The `feature-state` tag for this section was added in kubernetes#2754, however this section doesn't need a `feature-state` tag because the field is not gated by any feature gate: https://github.com/kubernetes/kubernetes/blob/90851a0fb5bbb6f02b3c22715f9f91609f8ee438/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1/types.go#L247-L251 It is now safe to remove the feature-state tag. Moreover, CRDs are now GA so the beta state is not accurate.
The Categories field for CRDs was documented as beta in 1.10 in kubernetes#7439 mainly because CRDs were in beta back then. The `feature-state` tag for this section was added in kubernetes#2754, however this section doesn't need a `feature-state` tag because the field is not gated by any feature gate: https://github.com/kubernetes/kubernetes/blob/90851a0fb5bbb6f02b3c22715f9f91609f8ee438/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1/types.go#L247-L251 It is now safe to remove the feature-state tag. Moreover, CRDs are now GA so the beta state is not accurate.
The Categories field for CRDs was documented as beta in 1.10 in kubernetes#7439 mainly because CRDs were in beta back then. The `feature-state` tag for this section was added in kubernetes#2754, however this section doesn't need a `feature-state` tag because the field is not gated by any feature gate: https://github.com/kubernetes/kubernetes/blob/90851a0fb5bbb6f02b3c22715f9f91609f8ee438/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1/types.go#L247-L251 It is now safe to remove the feature-state tag. Moreover, CRDs are now GA so the beta state is not accurate.
Secrets. An event documents the skipped keys from said resource.
This change is