Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh] Sych web page for topo manager #26363

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

chenxuc
Copy link
Contributor

@chenxuc chenxuc commented Feb 3, 2021

This is part of work in umbrella issue:
[zh] Umbrella issue: pages out of sync in tasks section #26178

Topology Manageer (L):
content/zh/docs/tasks/administer-cluster/topology-manager.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2021
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 3, 2021
@netlify
Copy link

netlify bot commented Feb 3, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e54d16c

https://deploy-preview-26363--kubernetes-io-master-staging.netlify.app

Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5ff4221160902bbf55941c63e838efadb540cc7f

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2021
@chenxuc
Copy link
Contributor Author

chenxuc commented Feb 4, 2021

@tengqm Thanks for the review. I've updated the commit.

This is part of work in umbrella issue:
[zh] Umbrella issue: pages out of sync in tasks section kubernetes#26178

Topology Manageer (L):
 content/zh/docs/tasks/administer-cluster/topology-manager.md
@chenxuc
Copy link
Contributor Author

chenxuc commented Feb 4, 2021

@tengqm I've fixed the link. thanks.

@tengqm
Copy link
Contributor

tengqm commented Feb 4, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 349423b7aee2cabb06519e2dd4f39dd8e4669bb2

Copy link
Member

@tanjunchen tanjunchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit fa2b8c8 into kubernetes:master Feb 6, 2021
@chenxuc chenxuc deleted the topo-manager branch February 23, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants