Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change capitalization of daemon name #26201

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

kbhawkey
Copy link
Contributor

Update NPD daemon name to sentence case (Node Problem Detector).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 22, 2021
@kbhawkey
Copy link
Contributor Author

Related to #24772.

@netlify
Copy link

netlify bot commented Jan 22, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a09fc68

https://deploy-preview-26201--kubernetes-io-master-staging.netlify.app

@bradtopol
Copy link
Contributor

/assign

@kbhawkey
Copy link
Contributor Author

@karan , Would you have time to look over these changes?

@karan
Copy link

karan commented Jan 25, 2021

/lgtm

Thanks for the follow up

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0a0681e1b4f3d3c4cac7270d0bedb547794380d6

*Node problem detector* is a daemon for monitoring and reporting about a node's health.
You can run node problem detector as a `DaemonSet`
or as a standalone daemon. Node problem detector collects information about node problems from various daemons
*Node Problem Detector* is a daemon for monitoring and reporting about a node's health.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@bradtopol
Copy link
Contributor

Great job! Verified that new updates are correct and render properly!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aut0R3V, bradtopol, ydFu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit f2810c8 into kubernetes:master Jan 25, 2021
@kbhawkey kbhawkey deleted the fix-nodedetector-caps branch February 1, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants