-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update service name in example of Name based virtual hosting #26185
Conversation
`service2` is mapped to `second.bar.com` in the given example ``` - host: second.bar.com http: paths: - pathType: Prefix path: "/" backend: service: name: service2 port: number: 80 ```
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @piyushjain18! |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 991b35f https://deploy-preview-26185--kubernetes-io-master-staging.netlify.app |
@@ -378,7 +378,7 @@ web traffic to the IP address of your Ingress controller can be matched without | |||
virtual host being required. | |||
|
|||
For example, the following Ingress routes traffic | |||
requested for `first.bar.com` to `service1`, `second.foo.com` to `service2`, and any traffic | |||
requested for `first.bar.com` to `service1`, `second.bar.com` to `service2`, and any traffic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch!!! Well done
/assign |
/lgtm |
LGTM label has been added. Git tree hash: c70b55446966dbf47227e9ccaf13277ea928e13f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bradtopol The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
service2
is mapped tosecond.bar.com
in the given example