-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify Design doc ttl-after-finish upstream #26132
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @chienfuchen32! |
✔️ Deploy preview for kubernetes-io-master-staging ready! 🔨 Explore the source changes: 9d3d554 🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/60084b695b91160007ff05ff 😎 Browse the preview: https://deploy-preview-26132--kubernetes-io-master-staging.netlify.app |
@chienfuchen32 |
4ce2b1a
to
1e1f7e0
Compare
1e1f7e0
to
9d3d554
Compare
/assign |
@@ -78,5 +78,5 @@ very small. Please be aware of this risk when setting a non-zero TTL. | |||
|
|||
* [Clean up Jobs automatically](/docs/concepts/workloads/controllers/job/#clean-up-finished-jobs-automatically) | |||
|
|||
* [Design doc](https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/0026-ttl-after-finish.md) | |||
* [Design doc](https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/592-ttl-after-finish/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verified that new link fixes the previous broken link and points to the correct KEP! Great job!
Verified that new link fixes the previous broken link and points to the correct KEP! Great job! |
LGTM label has been added. Git tree hash: b5efa9c3e7b712c3ae52797ba04f7d920e1ce761
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Aut0R3V, bradtopol The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.