Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Code blocks in configure-service-account.md #25969

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Add Code blocks in configure-service-account.md #25969

merged 1 commit into from
Jan 6, 2021

Conversation

ydFu
Copy link
Member

@ydFu ydFu commented Jan 6, 2021

  • Add Code blocks in the Markdown spec to make it easy to read.

  • Uniform case and adjustment description for smoother writing.

Signed-off-by: ydFu [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2021
@netlify
Copy link

netlify bot commented Jan 6, 2021 •
edited
Loading

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 8a479c0

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5ff5294bb5bdd4000757c67f

😎 Browse the preview: https://deploy-preview-25969--kubernetes-io-master-staging.netlify.app

tengqm
tengqm reviewed Jan 6, 2021
View reviewed changes
content/en/docs/tasks/configure-pod-container/configure-service-account.md Outdated
Comment on lines 205 to 207
```shell
kubectl get secrets myregistrykey
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This additional indentation is antipattern. Please change it back.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank,I will change it back.

@ydFu ydFu force-pushed the add-code-blocks-in-configure-service-account branch from 383957b to 9d3a449 Compare January 6, 2021 02:27
@ydFu
Add Code blocks in configure-service-account.md
8a479c0 
* Add Code blocks in the Markdown spec to make it easy to read.

* Uniform case and adjustment description for smoother writing.

Signed-off-by: ydFu <[email protected]>
@ydFu ydFu force-pushed the add-code-blocks-in-configure-service-account branch from 9d3a449 to 8a479c0 Compare January 6, 2021 03:06
@ydFu
Copy link
Member Author

ydFu commented Jan 6, 2021

@tengqm
Thanks for your advice,I adjusted the content.

@tengqm
Copy link
Contributor

tengqm commented Jan 6, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 73908d8d76076d41aeefb66c449fa80d5478db67

@ydFu
Copy link
Member Author

ydFu commented Jan 6, 2021 •
edited
Loading

/assign @savitharaghunathan

@kbhawkey
Copy link
Contributor

kbhawkey commented Jan 6, 2021

Page preview:
https://deploy-preview-25969--kubernetes-io-master-staging.netlify.app/docs/tasks/configure-pod-container/configure-service-account/

@kbhawkey
Copy link
Contributor

kbhawkey commented Jan 6, 2021

Thanks @ydFu .
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8fea26e into kubernetes:master Jan 6, 2021
@ydFu ydFu deleted the add-code-blocks-in-configure-service-account branch January 6, 2021 15:46
@ydFu ydFu mentioned this pull request Jan 30, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@liggitt liggitt Awaiting requested review from liggitt

@thockin thockin Awaiting requested review from thockin

Assignees

@tengqm tengqm

@savitharaghunathan savitharaghunathan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ydFu @tengqm @k8s-ci-robot @kbhawkey @savitharaghunathan