Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy feature gate EnableAggregatedDiscoveryTimeout for Aggregation layer #25460

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Remove legacy feature gate EnableAggregatedDiscoveryTimeout for Aggregation layer #25460

merged 1 commit into from
Mar 5, 2021

Conversation

gavinfish
Copy link
Contributor

@gavinfish gavinfish commented Dec 7, 2020 •
edited
Loading

Feature gate EnableAggregatedDiscoveryTimeout has been removed in version 1.17. Remove the legacy instruction here.
Details at kubernetes/kubernetes#82472.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 7, 2020
@gavinfish
Copy link
Contributor Author

/assign @kbarnard10

@netlify
Copy link

netlify bot commented Dec 7, 2020

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: e354338

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5fce3130d56b800009c44d09

😎 Browse the preview: https://deploy-preview-25460--kubernetes-io-master-staging.netlify.app

Aut0R3V
Aut0R3V reviewed Jan 13, 2021
View reviewed changes
content/en/docs/concepts/extend-kubernetes/api-extension/apiserver-aggregation.md
@@ -28,9 +28,7 @@ The most common way to implement the APIService is to run an *extension API serv
Extension API servers should have low latency networking to and from the kube-apiserver.
Discovery requests are required to round-trip from the kube-apiserver in five seconds or less.

If your extension API server cannot achieve that latency requirement, consider making changes that let you meet it. You can also set the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like shortening the content makes sense, so approving this. Maybe a member can approve/

@Aut0R3V Aut0R3V mentioned this pull request Jan 16, 2021
Closed
6 tasks
@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 5, 2021

Page preview:
https://deploy-preview-25460--kubernetes-io-master-staging.netlify.app/docs/concepts/extend-kubernetes/api-extension/apiserver-aggregation/#response-latency

@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 5, 2021

Thanks @gavinfish .
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7b1f09675fa8db018b00bb35b3861c786c60fc90

@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 5, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aut0R3V, kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 35e74c7 into kubernetes:master Mar 5, 2021
@gavinfish gavinfish deleted the EnableAggregatedDiscoveryTimeout branch March 5, 2021 01:32
@tengqm
Copy link
Contributor

tengqm commented Mar 5, 2021

#26849 is proposed to fix the integrity of the feature-gate table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aut0R3V Aut0R3V Aut0R3V approved these changes

@cheftako cheftako Awaiting requested review from cheftako

@chenopis chenopis Awaiting requested review from chenopis

Assignees

@kbhawkey kbhawkey

@kbarnard10 kbarnard10

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gavinfish @kbhawkey @k8s-ci-robot @tengqm @Aut0R3V @kbarnard10