Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidances for TLDs and Wildcard specification in YAML #24949

Closed
wants to merge 1 commit into from
Closed

Add guidances for TLDs and Wildcard specification in YAML #24949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions content/en/docs/concepts/services-networking/ingress.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,13 @@ example “`*.foo.com`”). Precise matches require that the HTTP `host` header
matches the `host` field. Wildcard matches require the HTTP `host` header is
equal to the suffix of the wildcard rule.


With respect to Wildcards and Top-level-domains (eg. .com, .ca, .org, .edu), there is
currently no support for specifying a wildcard in the format of `subdomain.domain.*`.
This would assume that the domain owner has access to and purchased all
Top-level-domains for their domain in order for this to be supported.
Comment on lines +206 to +209
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is needed @distributethe6ix

“Wildcard matches require the HTTP host header is equal to the suffix of the wildcard rule.” already covers this, I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@distributethe6ix

Suggested change
With respect to Wildcards and Top-level-domains (eg. .com, .ca, .org, .edu), there is
currently no support for specifying a wildcard in the format of `subdomain.domain.*`.
This would assume that the domain owner has access to and purchased all
Top-level-domains for their domain in order for this to be supported.

Remove this paragraph (accept the above suggestion) and we can merge this in?

Copy link
Author

@distributethe6ix distributethe6ix Mar 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Wildcard matches require the HTTP host header is equal to the suffix of the wildcard rule.” does not satisfy what the original issue was asking for.

With respect to Ingress, you cannot specify a Top level domain wild-card, hence why I added this bit into the documentation. It's not clear otherwise.

The top-level-domain is the ".com, .ca, .org, .io" for example, is not part of the "host-field"

The wildcard functionality does not address situations where someone who has purchased multiple domains can route accordingly to .ca, .com.

There is no option for host.foo.* <--- Wildcard at the TLD...

Happy to hop on a zoom/discord chat to further provide clarification.



| Host | Host header | Match? |
| ----------- |-------------------| --------------------------------------------------|
| `*.foo.com` | `bar.foo.com` | Matches based on shared suffix |
Expand Down