kudeadm: Replace "master" with "control plane node" #23847

devurandom · 2020-09-13T12:32:02Z

This replaces the word "master" with "control plane node" in order to use
more inclusive language.

Also uses consistent wording / spelling in this context.

References: #21621
Suggested-by: Lubomir I. Ivanov [email protected]

k8s-ci-robot · 2020-09-13T12:32:05Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-09-13T12:32:10Z

Welcome @devurandom!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

netlify · 2020-09-13T12:42:05Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 239bae6

https://deploy-preview-23847--kubernetes-io-master-staging.netlify.app

devurandom · 2020-09-13T12:46:37Z

To complete the pull request process, please assign savitharaghunathan
You can assign the PR to them by writing /assign @savitharaghunathan in a comment when ready.

/assign @savitharaghunathan

neolit123 · 2020-09-13T17:04:31Z

content/en/docs/setup/production-environment/tools/kubeadm/high-availability.md

@@ -36,7 +36,7 @@ LoadBalancer, or with dynamic PersistentVolumes.
 For both methods you need this infrastructure:

 - Three machines that meet [kubeadm's minimum requirements](/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#before-you-begin) for
-  the masters
+  the control plane nodes


@devurandom control-plane is more widely used, so better have with it with the dash in this document too:
https://github.com/kubernetes/website/search?q=%22control-plane%22&unscoped_q=%22control-plane%22

I get 476 results for "control plane", which includes "control-plane": https://github.com/kubernetes/website/search?q=%22control+plane%22&unscoped_q=%22control+plane%22
And 205 results for "control-plane": https://github.com/kubernetes/website/search?q=%22control-plane%22&unscoped_q=%22control-plane%22

So it is actually quite even. I will undo the change from "control-plane" to "control plane" in this document.

neolit123

thanks for the PR. added one comment.
/sig cluster-lifecycle

neolit123 · 2020-09-13T20:07:59Z

i think we have "control-plane" more consistent in the kubeadm related pages, but it's also in the source code of kubeadm for user facing text:
https://github.com/kubernetes/kubernetes/search?q=path%3A%2Fcmd%2Fkubeadm+%22control-plane%22&unscoped_q=path%3A%2Fcmd%2Fkubeadm+%22control-plane%22

so my preference is "control-plane" for this change.

content/en/docs/setup/production-environment/tools/kubeadm/high-availability.md

devurandom · 2020-09-14T06:03:31Z

so my preference is "control-plane" for this change.

Done in 4a78a30

neolit123 · 2020-09-14T11:27:17Z

Thanks. Please squash the commits to one.

This replaces the word "master" with "control-plane node" in order to use more inclusive language. Also uses consistent wording / spelling in this context. References: kubernetes#21621 Suggested-by: Lubomir I. Ivanov <[email protected]>

savitharaghunathan · 2020-09-20T13:07:03Z

Ping @neolit123 for tech review lgtm :)

neolit123

/lgtm
thanks

savitharaghunathan

/lgtm
/approve

k8s-ci-robot · 2020-09-20T14:37:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitharaghunathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [savitharaghunathan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 13, 2020

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 13, 2020

k8s-ci-robot requested review from bradtopol and kbarnard10 September 13, 2020 12:32

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Sep 13, 2020

devurandom mentioned this pull request Sep 13, 2020

Update terminology to be racially neutral #21621

Closed

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 13, 2020

k8s-ci-robot assigned savitharaghunathan Sep 13, 2020

neolit123 reviewed Sep 13, 2020

View reviewed changes

k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2020

devurandom commented Sep 14, 2020

View reviewed changes

content/en/docs/setup/production-environment/tools/kubeadm/high-availability.md Outdated Show resolved Hide resolved

devurandom commented Sep 14, 2020

View reviewed changes

content/en/docs/setup/production-environment/tools/kubeadm/high-availability.md Outdated Show resolved Hide resolved

devurandom force-pushed the patch-1 branch from 4a78a30 to 239bae6 Compare September 14, 2020 16:24

neolit123 reviewed Sep 20, 2020

View reviewed changes

k8s-ci-robot assigned neolit123 Sep 20, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2020

savitharaghunathan reviewed Sep 20, 2020

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2020

k8s-ci-robot merged commit 3f4b883 into kubernetes:master Sep 20, 2020

devurandom deleted the patch-1 branch October 13, 2020 06:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kudeadm: Replace "master" with "control plane node" #23847

kudeadm: Replace "master" with "control plane node" #23847

devurandom commented Sep 13, 2020

k8s-ci-robot commented Sep 13, 2020

k8s-ci-robot commented Sep 13, 2020

netlify bot commented Sep 13, 2020 •

edited

Loading

devurandom commented Sep 13, 2020

neolit123 Sep 13, 2020

devurandom Sep 13, 2020

neolit123 left a comment

neolit123 commented Sep 13, 2020

devurandom commented Sep 14, 2020

neolit123 commented Sep 14, 2020

savitharaghunathan commented Sep 20, 2020

neolit123 left a comment

savitharaghunathan left a comment

k8s-ci-robot commented Sep 20, 2020

kudeadm: Replace "master" with "control plane node" #23847

kudeadm: Replace "master" with "control plane node" #23847

Conversation

devurandom commented Sep 13, 2020

k8s-ci-robot commented Sep 13, 2020

k8s-ci-robot commented Sep 13, 2020

netlify bot commented Sep 13, 2020 • edited Loading

devurandom commented Sep 13, 2020

neolit123 Sep 13, 2020

Choose a reason for hiding this comment

devurandom Sep 13, 2020

Choose a reason for hiding this comment

neolit123 left a comment

Choose a reason for hiding this comment

neolit123 commented Sep 13, 2020

devurandom commented Sep 14, 2020

neolit123 commented Sep 14, 2020

savitharaghunathan commented Sep 20, 2020

neolit123 left a comment

Choose a reason for hiding this comment

savitharaghunathan left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 20, 2020

netlify bot commented Sep 13, 2020 •

edited

Loading