-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recover expansion failure docs #21920
Add recover expansion failure docs #21920
Conversation
Deploy preview for kubernetes-io-vnext-staging processing. Building with commit 67be842 https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f03a61e63235d000757cfed |
/milestone 1.19 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hello @gnufied . |
@gnufied: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
||
Once user requests expansion of a PVC then Kuberneretes attempts to expand the underlying volume continuously until | ||
volume is expanded to desired size. In some cases if underlying storage system can not provision requested capacity | ||
then it may be desirable to retry expansion with a lower value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need some copy editing from a native speaker I believe.
then it may be desirable to retry expansion with a lower value. | ||
|
||
To support this if feature-gate `RecoverExpansionFailure` is enabled then a user may reduce requested capacity upto value in `pvc.Status.Capacity` | ||
and retry volume expansion with a lower value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is not clear.
How is a user supposed to request a reduction of the requested capacity? By merely reducing the requested capacity or by specifying a delta value? The "upto value" is confusing.
Enhancement is not being tracked for 1.19 |
@annajung: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone clear |
@gnufied given that this PR is not targeted for the |
@jimangel: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add docs for volume expansion failure.
xref kubernetes/enhancements#1790