Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recover expansion failure docs #21920

Closed

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Jun 19, 2020

Add docs for volume expansion failure.

xref kubernetes/enhancements#1790

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jun 19, 2020

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 67be842

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f03a61e63235d000757cfed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2020
@k8s-ci-robot k8s-ci-robot requested review from msau42 and thockin June 19, 2020 16:22
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 19, 2020
@savitharaghunathan
Copy link
Member

/milestone 1.19
/assign

@gnufied gnufied changed the title WIP: Add recover expansion failure docs Add recover expansion failure docs Jul 6, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign savitharaghunathan
You can assign the PR to them by writing /assign @savitharaghunathan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kbhawkey
Copy link
Contributor

kbhawkey commented Jul 8, 2020

Hello @gnufied .
Would you rebase your changes? Thanks!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2020
@k8s-ci-robot
Copy link
Contributor

@gnufied: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Once user requests expansion of a PVC then Kuberneretes attempts to expand the underlying volume continuously until
volume is expanded to desired size. In some cases if underlying storage system can not provision requested capacity
then it may be desirable to retry expansion with a lower value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some copy editing from a native speaker I believe.

then it may be desirable to retry expansion with a lower value.

To support this if feature-gate `RecoverExpansionFailure` is enabled then a user may reduce requested capacity upto value in `pvc.Status.Capacity`
and retry volume expansion with a lower value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is not clear.
How is a user supposed to request a reduction of the requested capacity? By merely reducing the requested capacity or by specifying a delta value? The "upto value" is confusing.

@annajung
Copy link
Contributor

Enhancement is not being tracked for 1.19
/milestone clear

@k8s-ci-robot
Copy link
Contributor

@annajung: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

Enhancement is not being tracked for 1.19
/milestone clear

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@savitharaghunathan
Copy link
Member

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the 1.19 milestone Jul 14, 2020
@jimangel
Copy link
Member

@gnufied given that this PR is not targeted for the 1.19 release, I will close it now. If the plan is to have this land in 1.20 you may reopen this PR again targeting the new dev-1.20 branch once created. Thanks!
/close

@k8s-ci-robot
Copy link
Contributor

@jimangel: Closed this PR.

In response to this:

@gnufied given that this PR is not targeted for the 1.19 release, I will close it now. If the plan is to have this land in 1.20 you may reopen this PR again targeting the new dev-1.20 branch once created. Thanks!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants