Partial fix for debugging service page #21390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are kinda abusing the `{{ note }}` shortcode, which is not meant for
lengthy, verbose contents. We should not try include code snippets
inside a note.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
sig/docs
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit c4f9c35 https://deploy-preview-21390--kubernetes-io-master-staging.netlify.app |
sftim
reviewed
Jun 1, 2020
| @@ -61,8 +61,7 @@ kubectl scale deployment hostnames --replicas=3 | |||
| deployment.apps/hostnames scaled | |||
| ``` | |||
|
|
|||
| {{< note >}} | |||
| This is the same as if you had started the Deployment with the following | |||
| Note that this is the same as if you had started the Deployment with the following | |||
There was a problem hiding this comment.
For clarity (and to avoid future changes making this back into a note), I'd write:
Suggested change
| Note that this is the same as if you had started the Deployment with the following | |
| This is the same as if you had started the Deployment with the following |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Also relevant to #20335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are kinda abusing the
{{ note }}shortcode, which is not meant forlengthy, verbose contents. We should not try include code snippets
inside a note.
Related: #21388