Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the flag which controlls the cbr0's create #2126

Merged
merged 1 commit into from
Jan 23, 2017
Merged

change the flag which controlls the cbr0's create #2126

merged 1 commit into from
Jan 23, 2017

Conversation

chentao1596
Copy link

@chentao1596 chentao1596 commented Jan 4, 2017 •
edited by k8s-reviewable
Loading 

The flag "--configure-cbr0=true" has been removed, so we can't controller the cbr0's create by it. In fact, cbr0 will be created by kubelet if '--network-plugin=true', so i changed it, thank you!

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 4, 2017
@lavalamp lavalamp removed their assignment Jan 4, 2017
@thockin thockin assigned freehan and unassigned thockin Jan 6, 2017
@freehan
Copy link
Contributor

freehan commented Jan 6, 2017

Thanks! LGTM

@chenopis chenopis merged commit 621c895 into kubernetes:master Jan 23, 2017
@chentao1596 chentao1596 mentioned this pull request Oct 12, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@freehan freehan

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chentao1596 @freehan @lavalamp @thockin @k8s-ci-robot @chenopis @chentao11596