Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs/concepts/architecture/controller.md in portuguese #19805

Merged
merged 8 commits into from
Apr 3, 2020
Merged

Add docs/concepts/architecture/controller.md in portuguese #19805

merged 8 commits into from
Apr 3, 2020

Conversation

cloud-j-luna
Copy link
Contributor

Translation of docs/concepts/architecture/controller.md to portuguese.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 23, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @joao-luna-98!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/pt Issues or PRs related to Portuguese language labels Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 23, 2020
@cloud-j-luna
Copy link
Contributor Author

/assign @femrtnz

@netlify
Copy link

netlify bot commented Mar 23, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 28eac8e

https://deploy-preview-19805--kubernetes-io-master-staging.netlify.com

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2020
femrtnz
femrtnz reviewed Mar 26, 2020
View reviewed changes
Copy link
Member

@femrtnz femrtnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joao-luna-98 thanks for your help! Just put some suggestions here, please let me know if you have any questions

content/pt/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/pt/docs/reference/_index.md Outdated Show resolved Hide resolved
content/pt/docs/reference/glossary/controller.md Outdated Show resolved Hide resolved
content/pt/docs/reference/glossary/controller.md Outdated Show resolved Hide resolved
content/pt/docs/reference/glossary/controller.md Outdated Show resolved Hide resolved
content/pt/docs/reference/glossary/controller.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2020
@cloud-j-luna cloud-j-luna requested a review from femrtnz March 26, 2020 22:54
@devlware
Copy link
Contributor

Hey, I'll try to review it later tonight.

devlware
devlware requested changes Mar 29, 2020
View reviewed changes
Copy link
Contributor

@devlware devlware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello joao-luna-98, thanks for helping with the translation.
I left some comments for the first part of the docs that I reviewed. I'll be happy to discuss with you any point.
Regards

content/pt/docs/concepts/architecture/controller.md
sobre o seu *estado desejado*. A temperatura ambiente real é o
*estado atual*. O termostato atua de forma a trazer o estado atual
mais perto do estado desejado, ligando ou desligando o equipamento.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks like there is one missing phrase: "In Kubernetes, controllers are control loops that watch the state of your cluster, then make or request changes where needed. Each controller tries to move the current cluster state closer to the desired state." Can you check your translation againt the last revision of the docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the glossary entry for the controller term. It is translated in the references.

content/pt/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/architecture/controller.md Outdated Show resolved Hide resolved
@cloud-j-luna cloud-j-luna requested a review from devlware March 29, 2020 19:38
@femrtnz femrtnz mentioned this pull request Mar 30, 2020
Closed
@femrtnz
Copy link
Member

femrtnz commented Apr 2, 2020

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020
jhonmike
jhonmike reviewed Apr 2, 2020
View reviewed changes
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on the translation, I found only one adjustment at the end of the file

content/pt/docs/reference/glossary/controller.md Outdated Show resolved Hide resolved
@cloud-j-luna cloud-j-luna requested a review from jhonmike April 2, 2020 21:48
@jhonmike
Copy link
Member

jhonmike commented Apr 3, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: femrtnz, jhonmike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@femrtnz
Copy link
Member

femrtnz commented Apr 3, 2020

/hold cancel

@cloud-j-luna cloud-j-luna changed the title WIP Add docs/concepts/architecture/controller.md in portuguese Add docs/concepts/architecture/controller.md in portuguese Apr 3, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 81eb58a into kubernetes:master Apr 3, 2020
@cloud-j-luna cloud-j-luna deleted the translate-controllers branch April 3, 2020 14:44
This was referenced Apr 21, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@femrtnz femrtnz Awaiting requested review from femrtnz

@devlware devlware Awaiting requested review from devlware

@jhonmike jhonmike Awaiting requested review from jhonmike

Assignees

@jhonmike jhonmike

@femrtnz femrtnz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/pt Issues or PRs related to Portuguese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cloud-j-luna @k8s-ci-robot @devlware @femrtnz @jhonmike