Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IBM Cloud registry for IAM #19303

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Update IBM Cloud registry for IAM #19303

merged 1 commit into from
Feb 25, 2020

Conversation

artberger
Copy link
Contributor

Updates the topic to describe how to use IAM to authorize clusters to pull images from registry.

Update IBM Cloud registry for IAM
b6a9b99 
Updates the topic to describe how to use IAM to authorize clusters to pull images from registry.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 25, 2020
@netlify
Copy link

netlify bot commented Feb 25, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b6a9b99

https://deploy-preview-19303--kubernetes-io-master-staging.netlify.com

@bradtopol
Copy link
Contributor

/assign

bradtopol
bradtopol reviewed Feb 25, 2020
View reviewed changes
Copy link
Contributor

@bradtopol bradtopol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great.
I verified that all new links work properly

@bradtopol
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3f020e5 into kubernetes:master Feb 25, 2020
@artberger artberger deleted the adb-iccr-up branch February 25, 2020 17:33
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@artberger @wawa0210
Update IBM Cloud registry for IAM (kubernetes#19303)
0d01627 
Updates the topic to describe how to use IAM to authorize clusters to pull images from registry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradtopol bradtopol bradtopol left review comments

@tengqm tengqm Awaiting requested review from tengqm

@thockin thockin Awaiting requested review from thockin

Assignees

@bradtopol bradtopol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artberger @bradtopol @k8s-ci-robot