Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix en language misspell #18201

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Fix en language misspell #18201

merged 2 commits into from
Dec 20, 2019

Conversation

daixiang0
Copy link
Contributor

Signed-off-by: Xiang Dai [email protected]

Signed-off-by: Xiang Dai <[email protected]>
Signed-off-by: Xiang Dai <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 19, 2019
@daixiang0
Copy link
Contributor Author

If possible, i want to add tools:

  • check spell for en
  • clean up white noise for all markdown files

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2019
@daixiang0 daixiang0 requested a review from sftim December 19, 2019 10:54
@daixiang0
Copy link
Contributor Author

@sftim can i add a tool for all markdown files to clean up white noise in other PR?

@sftim
Copy link
Contributor

sftim commented Dec 19, 2019

@sftim can i add a tool for all markdown files to clean up white noise in other PR?
How about opening an issue to describe the improvement? That'd be a good place to put the discussion.

@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 20, 2019

@daixiang0 , Thank you for fixing the spelling errors. I reviewed the spelling changes in detail.
It would be best to limit cleanup of white space changes to one or two files per PR.
Sometimes the formatting of the page can be affected and reviewing the changes can take an extended period of time.

A few page previews:

https://deploy-preview-18201--kubernetes-io-master-staging.netlify.com/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/

https://deploy-preview-18201--kubernetes-io-master-staging.netlify.com/docs/setup/production-environment/windows/intro-windows-in-kubernetes/

https://deploy-preview-18201--kubernetes-io-master-staging.netlify.com/docs/contribute/style/content-guide/

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit f21f4b2 into kubernetes:master Dec 20, 2019
@daixiang0
Copy link
Contributor Author

@kbhawkey thanks for review, i would limit files sum in PRs and be careful about changes in web page.

@daixiang0 daixiang0 deleted the spell branch December 23, 2019 02:15
@kbhawkey
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants