Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to outdated files in the dev-1.17-ko.1 #18070

Merged
merged 7 commits into from
Dec 20, 2019
Merged

Update to outdated files in the dev-1.17-ko.1 #18070

merged 7 commits into from
Dec 20, 2019

Conversation

ysyukr
Copy link
Member

@ysyukr ysyukr commented Dec 10, 2019

28 out of 28 files to be modified

  • content/ko/_index.html
  • content/ko/docs/concepts/architecture/cloud-controller.md
  • content/ko/docs/concepts/architecture/nodes.md
  • content/ko/docs/concepts/overview/what-is-kubernetes.md
  • content/ko/docs/concepts/services-networking/endpoint-slices.md
  • content/ko/docs/concepts/workloads/controllers/daemonset.md
  • content/ko/docs/concepts/workloads/controllers/statefulset.md
  • content/ko/docs/concepts/workloads/controllers/ttlafterfinished.md
  • content/ko/docs/concepts/workloads/pods/pod-topology-spread-constraints.md
  • content/ko/docs/reference/_index.md
  • content/ko/docs/reference/glossary/cloud-provider.md
  • content/ko/docs/reference/glossary/etcd.md
  • content/ko/docs/reference/kubectl/cheatsheet.md
  • content/ko/docs/reference/using-api/client-libraries.md
  • content/ko/docs/setup/_index.md
  • content/ko/docs/setup/best-practices/certificates.md
  • content/ko/docs/setup/learning-environment/minikube.md
  • content/ko/docs/setup/production-environment/container-runtimes.md
  • content/ko/docs/setup/production-environment/tools/kops.md
  • content/ko/docs/setup/production-environment/windows/user-guide-windows-containers.md
  • content/ko/docs/tasks/access-application-cluster/configure-access-multiple-clusters.md
  • content/ko/docs/tasks/access-application-cluster/configure-dns-cluster.md
  • content/ko/docs/tasks/administer-cluster/cluster-management.md
  • content/ko/docs/tasks/manage-kubernetes-objects/kustomization.md
  • content/ko/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough.md
  • content/ko/docs/tasks/run-application/horizontal-pod-autoscale.md
  • content/ko/docs/tasks/tools/install-minikube.md
  • content/ko/docs/tutorials/configuration/configure-redis-using-configmap.md

from #18049
/language ko

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 10, 2019
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Dec 10, 2019
@netlify
Copy link

netlify bot commented Dec 15, 2019 •
edited
Loading

Deploy preview for k8s-dev-ko ready!

Built with commit 812453e

https://deploy-preview-18070--k8s-dev-ko.netlify.com

@gochist
Copy link
Member

gochist commented Dec 18, 2019

/assign

@seokho-son
Copy link
Member

/assign @seokho-son

seokho-son
seokho-son reviewed Dec 19, 2019
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysyukr Thank you for maintaining Korean l10n working branch !!
Please check my opinions and apply them if necessary.
Thank you !

content/ko/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/ko/docs/setup/production-environment/tools/kops.md Outdated Show resolved Hide resolved
content/ko/docs/setup/production-environment/windows/user-guide-windows-containers.md Outdated Show resolved Hide resolved
content/ko/docs/setup/production-environment/windows/user-guide-windows-containers.md Outdated Show resolved Hide resolved
content/ko/docs/setup/production-environment/windows/user-guide-windows-containers.md Outdated Show resolved Hide resolved
content/ko/docs/setup/production-environment/windows/user-guide-windows-containers.md Outdated Show resolved Hide resolved
content/ko/docs/tasks/tools/install-minikube.md Outdated Show resolved Hide resolved
@ysyukr
Copy link
Member Author

ysyukr commented Dec 19, 2019

@seokho-son 리뷰 감사합니다. 제안해주신 부분은 확인해서 반영했습니다.

@seokho-son
Copy link
Member

Thank you!
/lgtm
/approve

cc @gochist
This PR has been approved !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 92544b7 into kubernetes:dev-1.17-ko.1 Dec 20, 2019
@gochist gochist mentioned this pull request Dec 21, 2019
Merged
gochist pushed a commit that referenced this pull request Dec 21, 2019
@ysyukr @seokho-son @gochist
First Korean L10n Work For Relase 1.17
22ab60f 
* Modified link between Korean documents. (#18072)
* Translate services-networking/connect-applications-service.md in Korean. (#18087)
* Translate services-networking/service-topology.md in Korean. (#18096)
* Update to outdated files in the dev-1.17-ko.1 (#18070)

Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
k8s-ci-robot pushed a commit that referenced this pull request Dec 21, 2019
@gochist @ysyukr
@seokho-son @k8s-ci-robot
First Korean L10n Work For Relase 1.17 (#18226)
d60ca0b 
* Modified link between Korean documents. (#18072)
* Translate services-networking/connect-applications-service.md in Korean. (#18087)
* Translate services-networking/service-topology.md in Korean. (#18096)
* Update to outdated files in the dev-1.17-ko.1 (#18070)

Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>

Co-authored-by: Yuk, Yongsu <[email protected]>
Co-authored-by: Seokho Son <[email protected]>
@ysyukr ysyukr deleted the outdated-1.17-18049 branch January 3, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son left review comments

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

@ianychoi ianychoi Awaiting requested review from ianychoi

Assignees

@gochist gochist

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ysyukr @gochist @seokho-son @k8s-ci-robot