-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: disable owners inheritance for blog subproject #18007
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @zacharysarah |
Deploy preview for kubernetes-io-master-staging ready! Built with commit bbe10d0 https://deploy-preview-18007--kubernetes-io-master-staging.netlify.com |
Thank you, @idealhack! |
/lgtm |
/assign @kbarnard10 |
Thanks @idealhack! We previously removed this because it was causing blockers in PR review. For example, any release branch that touched the blog repo required our approval. Even small typo fixes and link changes. We removed it so that SIG-Docs approvers, especially the weekly PR wranglers could move more quickly to review and approve things that don't really need our sign off. My preference is to leave the permissions as is and we'll provide more training to SIG-Docs approvers on this process. Full details on the blog process can be found here for those following: https://github.com/kubernetes/community/tree/master/sig-docs/blog-subproject |
@kbarnard10 thanks for the explanation! |
address #16135 (comment)