Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: disable owners inheritance for blog subproject #18007

Closed
wants to merge 1 commit into from

Conversation

idealhack
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zacharysarah
You can assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 9, 2019
@idealhack
Copy link
Member Author

/assign @zacharysarah

@netlify
Copy link

netlify bot commented Dec 9, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit bbe10d0

https://deploy-preview-18007--kubernetes-io-master-staging.netlify.com

@onlydole
Copy link
Member

onlydole commented Dec 9, 2019

Thank you, @idealhack!

@onlydole
Copy link
Member

onlydole commented Dec 9, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2019
@onlydole
Copy link
Member

onlydole commented Dec 9, 2019

/assign @kbarnard10

@kbarnard10
Copy link
Contributor

Thanks @idealhack! We previously removed this because it was causing blockers in PR review. For example, any release branch that touched the blog repo required our approval. Even small typo fixes and link changes.

We removed it so that SIG-Docs approvers, especially the weekly PR wranglers could move more quickly to review and approve things that don't really need our sign off.

My preference is to leave the permissions as is and we'll provide more training to SIG-Docs approvers on this process.

Full details on the blog process can be found here for those following: https://github.com/kubernetes/community/tree/master/sig-docs/blog-subproject

@idealhack
Copy link
Member Author

@kbarnard10 thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants