Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert breaking commits #17967

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Revert breaking commits #17967

merged 2 commits into from
Dec 5, 2019

Conversation

zacharysarah
Copy link
Contributor

This PR reverts #17888 and #17889 because they contain GitHub keywords in their commit messages and cause Prow warnings.

@tengqm Please resubmit #17888 and #17889 without GitHub keywords in PR titles or commit messages.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 5, 2019
@zacharysarah zacharysarah mentioned this pull request Dec 5, 2019
Merged
@netlify
Copy link

netlify bot commented Dec 5, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0f0b7d2

https://deploy-preview-17967--kubernetes-io-master-staging.netlify.com

bradtopol
bradtopol approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@bradtopol bradtopol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@bradtopol
Copy link
Contributor

/assign

@bradtopol
Copy link
Contributor

Good plan!!!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit bb45a98 into kubernetes:master Dec 5, 2019
@zacharysarah zacharysarah deleted the revert-breaking-commits branch December 5, 2019 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradtopol bradtopol bradtopol approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@krousey krousey Awaiting requested review from krousey

Assignees

@bradtopol bradtopol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zacharysarah @bradtopol @k8s-ci-robot