Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate services-networking/ingress.md in Korean. #17807

Merged
merged 5 commits into from
Dec 5, 2019
Merged

Translate services-networking/ingress.md in Korean. #17807

merged 5 commits into from
Dec 5, 2019

Conversation

ysyukr
Copy link
Member

@ysyukr ysyukr commented Nov 26, 2019

문서를 번역했습니다.
리뷰 부탁드립니다.

#17729
/language ko

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 26, 2019
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 26, 2019
@netlify
Copy link

netlify bot commented Nov 26, 2019

Deploy preview for k8s-dev-ko ready!

Built with commit 3162fe5

https://deploy-preview-17807--k8s-dev-ko.netlify.com

@gochist
Copy link
Member

gochist commented Nov 27, 2019

/assign @claudiajkang

Copy link
Contributor

@claudiajkang claudiajkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysyukr PR 감사합니다. 리뷰가 늦어진 점 사과드립니다.

리뷰 확인 부탁드립니다.

content/ko/docs/concepts/services-networking/ingress.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress.md Outdated Show resolved Hide resolved
@ysyukr
Copy link
Member Author

ysyukr commented Dec 4, 2019

@claudiajkang 검토 감사합니다!
제안해주신 내용은 확인해서 반영했습니다 :)

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysyukr 지나가다가.. 오타가 보여서 의견 드립니다 :)
확실히 한글되어 있으니 금방 읽을 수 있네요. 감사합니다 ~ !

content/ko/docs/concepts/services-networking/ingress.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress.md Outdated Show resolved Hide resolved
content/ko/docs/concepts/services-networking/ingress.md Outdated Show resolved Hide resolved
@ysyukr
Copy link
Member Author

ysyukr commented Dec 4, 2019

@seokho-son 리뷰 감사합니다 :)
주신 제안은 확인해서 반영했습니다!

Copy link
Contributor

@claudiajkang claudiajkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysyukr 감사합니다.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ClaudiaJKang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit f3f0b1f into kubernetes:dev-1.16-ko.6 Dec 5, 2019
gochist pushed a commit that referenced this pull request Dec 6, 2019
* Update _index.md (#17762)
* Update apparmor.md (#17767)
* Update hello-minikube.md (#17771)
* Update guestbook.md (#17773)
* Update localization_ko.md (#17777)
* Fix grammatical errors (#17776)
* Translate /docs/reference/issues-security/security.md in Korea (#17763)
* Create issues.md (#17765)
* Update basic-stateful-set.md (#17774)
* Fixed typo ko/docs/concepts/overview/components.md (#17778)
* Modify typo. (#17802)
* Update cloud-controller.md (#17760)
* Update file outdated korean docs in dev-1.16-ko.6. (#17772)
* Translate concepts/services-networking/ingress-controller in Korean (#17858)
* Update ingress-controller.md
* Translate services-networking/ingress.md in Korean. (#17807)
* Fix grammatical errors (#17775)
* Translate docs/contribute/style/write-new-topic.md in Korean (#17758)

Co-Authored-By: const-k <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: power8993 <[email protected]>
Co-Authored-By: reung37 <[email protected]>
Co-Authored-By: Chihoon-Sung <[email protected]>
Co-Authored-By: Claudia J.Kang <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
k8s-ci-robot pushed a commit that referenced this pull request Dec 6, 2019
* Update _index.md (#17762)
* Update apparmor.md (#17767)
* Update hello-minikube.md (#17771)
* Update guestbook.md (#17773)
* Update localization_ko.md (#17777)
* Fix grammatical errors (#17776)
* Translate /docs/reference/issues-security/security.md in Korea (#17763)
* Create issues.md (#17765)
* Update basic-stateful-set.md (#17774)
* Fixed typo ko/docs/concepts/overview/components.md (#17778)
* Modify typo. (#17802)
* Update cloud-controller.md (#17760)
* Update file outdated korean docs in dev-1.16-ko.6. (#17772)
* Translate concepts/services-networking/ingress-controller in Korean (#17858)
* Update ingress-controller.md
* Translate services-networking/ingress.md in Korean. (#17807)
* Fix grammatical errors (#17775)
* Translate docs/contribute/style/write-new-topic.md in Korean (#17758)

Co-Authored-By: const-k <[email protected]>
Co-Authored-By: Yuk, Yongsu <[email protected]>
Co-Authored-By: power8993 <[email protected]>
Co-Authored-By: reung37 <[email protected]>
Co-Authored-By: Chihoon-Sung <[email protected]>
Co-Authored-By: Claudia J.Kang <[email protected]>
Co-Authored-By: Seokho Son <[email protected]>
@ysyukr ysyukr deleted the translate-17729 branch December 11, 2019 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants