Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs/tutorials]: update kube-state-metrics install details #17570

Merged
merged 1 commit into from
Nov 18, 2019
Merged

[docs/tutorials]: update kube-state-metrics install details #17570

merged 1 commit into from
Nov 18, 2019

Conversation

tariq1890
Copy link
Contributor

Kube-state-metrics installation steps have been updated since this tutorial was published.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 14, 2019
@netlify
Copy link

netlify bot commented Nov 14, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4171811

https://deploy-preview-17570--kubernetes-io-master-staging.netlify.com

@tariq1890 tariq1890 mentioned this pull request Nov 14, 2019
Closed
@pigletfly
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2019
@pigletfly
Copy link
Member

thanks for your updating @tariq1890

@seokho-son
Copy link
Member

seokho-son commented Nov 16, 2019 •
edited
Loading

Contents in Ko are translation of original docs(En).
So, the Ko contents can be changed along with En docs.
Since this PR got lgtm from En reviewer, as an Ko contents approver, I'd like to give lgtm. @tariq1890 Thank you for the contribution!!
/lgtm
/approve

@nikhita
Copy link
Member

nikhita commented Nov 18, 2019

@seokho-son can you approve again? Prow doesn't pick up edited comments for approval 😬

@seokho-son
Copy link
Member

@nikhita Sure ! Thank you :)
/approve

@makoscafee
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: makoscafee, seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1ef778e into kubernetes:master Nov 18, 2019
@tariq1890 tariq1890 deleted the upd_ksm branch November 18, 2019 22:00
@tariq1890
Copy link
Contributor Author

Thanks all for helping to get this PR in :).

@ysyukr ysyukr mentioned this pull request Nov 23, 2019
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pigletfly pigletfly pigletfly approved these changes

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

@sftim sftim Awaiting requested review from sftim

Assignees

@pigletfly pigletfly

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tariq1890 @pigletfly @seokho-son @nikhita @makoscafee @k8s-ci-robot