Release Notes (correction)

[butuzov]

The link to the CRD page ( check link in CustomResourceDefaulting
description of Beta section) corrected (before its was generating 404
due to an encoded anchor symbol.).

[butuzov]

/assign @tengqm

[netlify]

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2a56429

https://deploy-preview-17559--kubernetes-io-master-staging.netlify.com

[sftim]

/lgtm

[sftim]

Does this need correcting anywhere upstream? Or a fix to the generator code?

[butuzov]

@sftim good and valid point. kubernetes/kubernetes#82252 and kubernetes/kubernetes#81872 both introducing a link with anchor: one proccessed "ok", one "isn't".

Who can we ask about the generator and how it works?

[tengqm]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• content/en/OWNERS [tengqm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tengqm]

I just did some research on this. It looks like the upstream code is here:
https://github.com/kubernetes/release/blob/master/pkg/notes/notes.go#L519

For release notes to be properly processed by the code, the notes itself is supposed to be put under "Does this PR introduce a user-facing change" section in the commit message. E.g. kubernetes/kubernetes/#82252For some reasons, we have PRs not doing this, e.g. kubernetes/kubernetes/#81872. The generator has some logic to process the notes in different ways: https://github.com/kubernetes/release/blob/master/pkg/notes/notes.go#L262

[butuzov]

@tengqm Will you handle it? (i am not familiar with release tools) or I guess there is a slack channel about releases where members can be interested in this info...