Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fluentd image #16943

Closed
wants to merge 1 commit into from
Closed

Fix fluentd image #16943

wants to merge 1 commit into from

Conversation

ialidzhikov
Copy link
Contributor

fluentd image was moved from gcr.io to quay.io - ref kubernetes/kubernetes#79390.
Currently the image pull fails:

docker pull gcr.io/fluentd-elasticsearch/fluentd:v2.5.1
Error response from daemon: pull access denied for gcr.io/fluentd-elasticsearch/fluentd, repository does not exist or may require 'docker login': denied: Permission denied for "v2.5.1" from request "/v2/fluentd-elasticsearch/fluentd/manifests/v2.5.1".

/kind bug

@ialidzhikov
Fix fluentd image
7980f8a 
Signed-off-by: ialidzhikov <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 15, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 15, 2019
@ialidzhikov
Copy link
Contributor Author

/assign @zacharysarah

@netlify
Copy link

netlify bot commented Oct 15, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 7980f8a

https://deploy-preview-16943--kubernetes-io-master-staging.netlify.com

chenrui333
chenrui333 approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2019
@chenrui333
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chenrui333
To complete the pull request process, please assign zacharysarah
You can assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zacharysarah
Copy link
Contributor

@ialidzhikov Thanks for the update. Per the style guide, please limit PRs to one language per PR. In this case, this one PR needs to become 4 separate PRs, one per language. Thanks in advance!

This was referenced Oct 16, 2019
Merged
Merged
Merged
Merged
@ialidzhikov
Copy link
Contributor Author

Thanks for the hint @zacharysarah. Linked the per language PRs. PTAL :)

@ialidzhikov ialidzhikov deleted the fix/fluentd-image branch October 16, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@ianychoi ianychoi Awaiting requested review from ianychoi

Assignees

@chenrui333 chenrui333

@zacharysarah zacharysarah

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ialidzhikov @chenrui333 @k8s-ci-robot @zacharysarah