Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update announcing-etcd-3.4.md #16205

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Update announcing-etcd-3.4.md #16205

merged 1 commit into from
Sep 13, 2019

Conversation

jingyih
Copy link
Contributor

@jingyih jingyih commented Sep 3, 2019

Remove mentioning of using concurrent read in compaction. The original PR etcd-io/etcd#11021 was superseded by etcd-io/etcd#11034, which no long uses concurrent read in compaction.

/cc @gyuho

@k8s-ci-robot
Copy link
Contributor

Welcome @jingyih!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from gyuho September 3, 2019 19:49
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2019
@gyuho
Copy link
Member

gyuho commented Sep 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2019
@jingyih
Copy link
Contributor Author

jingyih commented Sep 4, 2019

/cc @WIZARD-CXY

@k8s-ci-robot
Copy link
Contributor

@jingyih: GitHub didn't allow me to request PR reviews from the following users: WIZARD-CXY.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @WIZARD-CXY

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@WIZARD-CXY
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@WIZARD-CXY: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jimangel
Copy link
Member

jimangel commented Sep 5, 2019

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2019
@kbhawkey
Copy link
Contributor

hello @jingyih .
The build/deploy preview appears to be stalled. Could you try to post an empty commit or rebase the PR? Thanks.

@jingyih
Update announcing-etcd-3.4.md
73e9a9e 
Remove mentioning of using concurrent read in compaction. The original PR etcd-io/etcd#11021 was superseded by etcd-io/etcd#11034, which no long uses concurrent read in compaction.
@jingyih jingyih force-pushed the update-announcing-etcd-3p4 branch from 9a70e27 to 73e9a9e Compare September 13, 2019 18:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2019
@jingyih
Copy link
Contributor Author

jingyih commented Sep 13, 2019

hello @jingyih .
The build/deploy preview appears to be stalled. Could you try to post an empty commit or rebase the PR? Thanks.

Rebased.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Sep 13, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 73e9a9e

https://deploy-preview-16205--kubernetes-io-master-staging.netlify.com

@kbhawkey
Copy link
Contributor

Page preview:
https://deploy-preview-16205--kubernetes-io-master-staging.netlify.com/blog/

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit a7d6c57 into kubernetes:master Sep 13, 2019
it2911 pushed a commit to it2911/kubernetes-website that referenced this pull request Sep 17, 2019
@jingyih @it2911
Update announcing-etcd-3.4.md (kubernetes#16205)
3ac6e0c 
Remove mentioning of using concurrent read in compaction. The original PR etcd-io/etcd#11021 was superseded by etcd-io/etcd#11034, which no long uses concurrent read in compaction.
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 18, 2019
@jingyih @wahyuoi
Update announcing-etcd-3.4.md (kubernetes#16205)
9de5713 
Remove mentioning of using concurrent read in compaction. The original PR etcd-io/etcd#11021 was superseded by etcd-io/etcd#11034, which no long uses concurrent read in compaction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyuho gyuho Awaiting requested review from gyuho

Assignees

@kbhawkey kbhawkey

@gyuho gyuho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jingyih @k8s-ci-robot @gyuho @WIZARD-CXY @jimangel @kbhawkey