Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS-DE] Tutorial hello-minikube #13526

Merged
merged 2 commits into from
Apr 5, 2019
Merged

[DOCS-DE] Tutorial hello-minikube #13526

merged 2 commits into from
Apr 5, 2019

Conversation

bene2k1
Copy link
Member

@bene2k1 bene2k1 commented Mar 29, 2019

Deutsche Übersetzung des Tutorials "Hello Minikube"
German translation of the tutorial "hello minikube"

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/de Issues or PRs related to German language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 29, 2019
@netlify
Copy link

netlify bot commented Mar 29, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8bcec15

https://deploy-preview-13526--kubernetes-io-master-staging.netlify.com

rlenferink
rlenferink reviewed Mar 31, 2019
View reviewed changes
content/de/docs/tutorials/_index.md Outdated Show resolved Hide resolved
content/de/docs/tutorials/hello-minikube.md Outdated Show resolved Hide resolved
content/de/docs/tutorials/hello-minikube.md Outdated Show resolved Hide resolved
content/de/docs/tutorials/hello-minikube.md Outdated Show resolved Hide resolved
content/de/docs/tutorials/hello-minikube.md Outdated Show resolved Hide resolved
@rlenferink
Copy link
Member

Ping @bene2k1 for processing feedback :)

@rlenferink rlenferink self-assigned this Apr 4, 2019
@rlenferink
Copy link
Member

Thanks for solving the remarks 🎉

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rlenferink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0ee892d into kubernetes:master Apr 5, 2019
@bene2k1 bene2k1 deleted the hello_minikube branch April 19, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlenferink rlenferink rlenferink left review comments

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@rlenferink rlenferink

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bene2k1 @rlenferink @k8s-ci-robot