Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change API version to v1 in the example of Priority doc #13457

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Change API version to v1 in the example of Priority doc #13457

merged 1 commit into from
Mar 27, 2019

Conversation

bsalamat
Copy link
Member

Not sure if I should choose "release-1.14" or "master" for this PR. I would like this change to be applied to both release-1.14 and master.

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 26, 2019
@bsalamat
Copy link
Member Author

ref/ kubernetes/enhancements#564

@bsalamat bsalamat changed the title Change API version to v1 in Priority example file Change API version to v1 in the example of Priority doc Mar 26, 2019
@netlify
Copy link

netlify bot commented Mar 26, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 10f761a

https://deploy-preview-13457--kubernetes-io-master-staging.netlify.com

@bsalamat
Copy link
Member Author

/assign @Huang-Wei

@jimangel
Copy link
Member

Thanks @bsalamat!

If we merge it to master, it will eventually be merged to release-1.14 as we keep that up-to-date from master during the release cycle.

For additional context, the kubernetes.io site is built out of master (1.14) until 1.15 is released then the 1.14 docs will come from release-1.14.

Huang-Wei
Huang-Wei reviewed Mar 26, 2019
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. Please see below.

BTW: I'm curious why commit 94eb0be is empty.

content/en/docs/concepts/configuration/pod-priority-preemption.md Outdated
@@ -34,7 +34,7 @@ Kubernetes Version | Priority and Preemption State | Enabled by default
1.9 | alpha | no
1.10 | alpha | no
1.11 | beta | yes
1.14 | GA | yes
1.14 | stable | yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1.14 | stable | yes
1.14 | stable | yes

BTW: does this mean it's more preferable to use the word stable over GA?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. Looks like we use stable instead of 'GA' in our documents.

@Huang-Wei
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2019
@tengqm
Copy link
Contributor

tengqm commented Mar 27, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2019
@tengqm tengqm merged commit bbe35dc into kubernetes:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Huang-Wei left review comments

@davidopp davidopp Awaiting requested review from davidopp

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@Huang-Wei Huang-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bsalamat @jimangel @Huang-Wei @tengqm @k8s-ci-robot