Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codenew shortcode to configure-pod-configmap task file and saniti… #13078

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Add codenew shortcode to configure-pod-configmap task file and saniti… #13078

merged 1 commit into from
Mar 12, 2019

Conversation

DanyC97
Copy link
Contributor

@DanyC97 DanyC97 commented Mar 11, 2019

…ze the example files

This PR is part of the initiative started #12740

Fixes #13057

cc @Bradamant3 @zacharysarah

fyi i had to "refresh" the whole task file to bring it inline with the rest of the files hence the amount of changes

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/en Issues or PRs related to English language labels Mar 11, 2019
@netlify
Copy link

netlify bot commented Mar 11, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 96bbc4d

https://deploy-preview-13078--kubernetes-io-master-staging.netlify.com

zacharysarah
zacharysarah suggested changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanyC97 👋 Thanks for opening this PR! Some feedback:

🙇

  • It looks like you accidentally introduced some spelling errors. ("ConfgMap")

Please double check to make sure that others haven't been introduced as well.

Hugo requires test cases for each new YAML file. You can add them to content/en/examples/examples_test.go, using existing test cases as a basis.

content/en/docs/tasks/configure-pod-container/configure-pod-configmap.md Outdated

1. Use `envFrom` to define all of the ConfigMap's data as container environment variables. The key from the ConfigMap becomes the environment variable name in the Pod.
Create the ConfgMap:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConfgMap/ConfigMap

content/en/docs/tasks/configure-pod-container/configure-pod-configmap.md Outdated
special.type: charm
{{< codenew file="configmap/configmap-multikeys.yaml" >}}

Create the ConfgMap:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConfgMap/ConfigMap

content/en/docs/tasks/configure-pod-container/configure-pod-configmap.md Outdated
key: log_level
restartPolicy: Never
```
Create the ConfgMap:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConfgMap/ConfigMap

@DanyC97 DanyC97 force-pushed the tasks-cpc-configmap branch 2 times, most recently from c55e605 to 0ed7ba1 Compare March 11, 2019 23:18
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2019
@DanyC97 DanyC97 force-pushed the tasks-cpc-configmap branch from 0ed7ba1 to 96bbc4d Compare March 11, 2019 23:26
@tengqm
Copy link
Contributor

tengqm commented Mar 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2019
@zacharysarah
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit e38f800 into kubernetes:master Mar 12, 2019
@DanyC97 DanyC97 deleted the tasks-cpc-configmap branch March 12, 2019 10:21
This was referenced Mar 12, 2019
Merged
Closed
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@DanyC97 @yagonobre
Add codenew shortcode to configure-pod-configmap task file and saniti…
9cb60a0 
…ze the example files (kubernetes#13078)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharysarah zacharysarah zacharysarah requested changes

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanyC97 @tengqm @zacharysarah @k8s-ci-robot