Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12764 - Update troubleshooting-kubeadm doc #12825

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Fix #12764 - Update troubleshooting-kubeadm doc #12825

merged 1 commit into from
Feb 27, 2019

Conversation

daminisatya
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2019
@daminisatya
Copy link
Contributor Author

/assign @neolit123

@netlify
Copy link

netlify bot commented Feb 25, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b47db0e

https://deploy-preview-12825--kubernetes-io-master-staging.netlify.com

neolit123
neolit123 reviewed Feb 25, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @daminisatya
suggested a couple of minor changes.

content/en/docs/setup/independent/troubleshooting-kubeadm.md Outdated
@@ -155,6 +155,18 @@ Unable to connect to the server: x509: certificate signed by unknown authority (
regenerate a certificate if necessary. The certificates in a kubeconfig file
are base64 encoded. The `base64 -d` command can be used to decode the certificate
and `openssl x509 -text -noout` can be used for viewing the certificate information.
- Verify that the env variable `KUBECONFIG` is set to `NULL` using:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unset the the KUBECONFIG environment variable using:

content/en/docs/setup/independent/troubleshooting-kubeadm.md Outdated
unset KUBECONFIG
```

Or set it to the correct config file using:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or set it to the default kubeconfig location:

@daminisatya
Copy link
Contributor Author

@neolit123 Thank you for the review! I updated the PR with the suggestions

neolit123
neolit123 reviewed Feb 25, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2019
@Rajakavitha1
Copy link
Contributor

Checked the updates on: https://deploy-preview-12825--kubernetes-io-master-staging.netlify.com/docs/setup/independent/troubleshooting-kubeadm/

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajakavitha1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8598dc5 into kubernetes:master Feb 27, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@daminisatya
Fix kubernetes#12764 - Update troubleshooting-kubeadm doc (kubernetes…
7f05938 
…#12825)
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@daminisatya
Fix kubernetes#12764 - Update troubleshooting-kubeadm doc (kubernetes…
e3fe86e 
…#12825)
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@daminisatya @yagonobre
Fix kubernetes#12764 - Update troubleshooting-kubeadm doc (kubernetes…
8b80337 
…#12825)
@daminisatya daminisatya deleted the tls_cert_fix branch March 20, 2019 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daminisatya @Rajakavitha1 @k8s-ci-robot @neolit123