Move Docker credentials import to task documentation #12668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 70d6577 https://deploy-preview-12668--kubernetes-io-master-staging.netlify.com |
zparnold
reviewed
Feb 18, 2019
| If you need access to multiple registries, you can create one secret for each registry. | ||
| Kubelet will merge any `imagePullSecrets` into a single virtual `.docker/config.json` | ||
| when pulling images for your Pods. | ||
| If you already have a Docker credentials file, you can import this instead, |
There was a problem hiding this comment.
This isn't quite a complete sentence. Can you please explain how someone could import a Docker credentials file?
There was a problem hiding this comment.
Oops, wrong punctuation.
zparnold
reviewed
Feb 18, 2019
| type: kubernetes.io/dockerconfigjson | ||
| ``` | ||
|
|
||
| If you get the error message `error: no objects passed to create`, it may mean the base64 encoded string is invalid. |
There was a problem hiding this comment.
Credit to a0fb30a on that one. I'm really just editing what's already there.
|
/assign @thockin |
|
@thockin could you please review the updated content for technical accuracy. |
|
/tech review |
sftim
force-pushed
the
docker_credentials_pull_image_private_registry
branch
from
87c83b2 to
70d6577
Compare
|
Can we please assign to someone else. I am swamped right now.
…On Mon, Feb 18, 2019 at 5:45 AM Tim Bannister ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
content/en/docs/tasks/configure-pod-container/pull-image-private-registry.md
<#12668 (comment)>:
> +- set `type` to `kubernetes.io/dockerconfigjson` <http://kubernetes.io/dockerconfigjson>
+
+Example:
+
+```yaml
+apiVersion: v1
+kind: Secret
+metadata:
+ name: myregistrykey
+ namespace: awesomeapps
+data:
+ .dockerconfigjson: UmVhbGx5IHJlYWxseSByZWVlZWVlZWVlZWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWxsbGxsbGxsbGxsbGxsbGxsbGxsbGxsbGxsbGxsbGx5eXl5eXl5eXl5eXl5eXl5eXl5eSBsbGxsbGxsbGxsbGxsbG9vb29vb29vb29vb29vb29vb29vb29vb29vb25ubm5ubm5ubm5ubm5ubm5ubm5ubm5ubmdnZ2dnZ2dnZ2dnZ2dnZ2dnZ2cgYXV0aCBrZXlzCg==
+type: kubernetes.io/dockerconfigjson
+```
+
+If you get the error message `error: no objects passed to create`, it may mean the base64 encoded string is invalid.
Credit to f0cd49a
<f0cd49a>
on that one. I'm really just editing what's already there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12668 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVJzr_JvX-SJr185e9K0jtIfGMyLaks5vOq5cgaJpZM4a_CPC>
.
|
|
/unassign @thockin |
|
/assign @zparnold |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zparnold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kwiesmueller
pushed a commit
to kwiesmueller/website
that referenced
this pull request
Feb 28, 2019
* Move docker credentials import to task documentation Relevant to kubernetes#12072 * Call out helpful note about per-namespace secrets
krmayankk
pushed a commit
to krmayankk/kubernetes.github.io
that referenced
this pull request
Mar 11, 2019
* Move docker credentials import to task documentation Relevant to kubernetes#12072 * Call out helpful note about per-namespace secrets
yagonobre
pushed a commit
to yagonobre/website
that referenced
this pull request
Mar 14, 2019
* Move docker credentials import to task documentation Relevant to kubernetes#12072 * Call out helpful note about per-namespace secrets
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that the information about pulling from multiple registries is still available in https://kubernetes.io/docs/concepts/containers/images/ (by hyperlinking to its new home).
The text about configuring multiple registries moves into https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/
This explanation is task-oriented and is useful to readers who are already familiar with:
as isolated concepts.