Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add “app container” to glossary #12611

Merged
merged 4 commits into from
Mar 7, 2019
Merged

Add “app container” to glossary #12611

merged 4 commits into from
Mar 7, 2019

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Feb 12, 2019

Associated with #5993

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2019
@netlify
Copy link

netlify bot commented Feb 12, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ec8efb1

https://deploy-preview-12611--kubernetes-io-master-staging.netlify.com

@zparnold
Copy link
Member

@sftim To have some context, is the concept of init-container documented as a glossary item?

@sftim
Copy link
Contributor Author

sftim commented Feb 13, 2019

There is a glossary entry for init container, and it reads:

One or more initialization containers that must run to completion before any app containers run.

Initialization (init) containers are like regular app containers, with one difference: init containers must run to completion before any app containers can start. Init containers run in series: each init container must run to completion before the next init container begins.

@zparnold
Copy link
Member

@sftim Now that workload definition has been merged, do you think it'd be good to link that as a reference here?

@sftim sftim force-pushed the glossary_app_container branch from d0b1ae4 to beb3de7 Compare February 18, 2019 13:15
@sftim
Copy link
Contributor Author

sftim commented Feb 18, 2019

Expanded the definition a bit, including a cross-reference to workload (as @zparnold suggested)

@zparnold
Copy link
Member

@sftim One slight nit, then it's good to go.
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 28, 2019
@zparnold @sftim
Tweak wording
97f8872 
Co-Authored-By: Zach Arnold <[email protected]>
@sftim sftim force-pushed the glossary_app_container branch from 272b071 to 97f8872 Compare February 28, 2019 09:30
@sftim
Copy link
Contributor Author

sftim commented Feb 28, 2019

@zparnold Could you review this once more?

@Bradamant3
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5c99d34 into kubernetes:master Mar 7, 2019
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@sftim
Add “app container” to glossary (kubernetes#12611)
206cf69 
* Define "app container"

* Expand app container explanation

* Tweak wording

Co-Authored-By: Zach Arnold <[email protected]>

* Fix, wording nit
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@sftim @yagonobre
Add “app container” to glossary (kubernetes#12611)
0fe03a8 
* Define "app container"

* Expand app container explanation

* Tweak wording

Co-Authored-By: Zach Arnold <[email protected]>

* Fix, wording nit
@sftim sftim mentioned this pull request May 7, 2019
Closed
6 tasks
@sftim sftim deleted the glossary_app_container branch June 9, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zparnold zparnold zparnold left review comments

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@zparnold zparnold

@Bradamant3 Bradamant3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sftim @zparnold @Bradamant3 @k8s-ci-robot