Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ambassador to list of ingress options #12582

Closed
wants to merge 1 commit into from

Conversation

danielbryantuk
Copy link
Contributor

Ambassador is an open source Kubernetes-native API gateway built on the Envoy Proxy that adds ingress and API gateway functionality via Service annotations. I would like to add this to the list of options in the ingress documentation please.

Ambassador is an open source Kubernetes-native API gateway built on the Envoy Proxy that adds ingress and API gateway functionality via Service annotations. I would like to add this to the list of options in the ingress documentation please.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zacharysarah

If they are not already assigned, you can assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 11, 2019
@netlify
Copy link

netlify bot commented Feb 11, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit bea18d3

https://deploy-preview-12582--kubernetes-io-master-staging.netlify.com

@zparnold
Copy link
Member

@danielbryantuk Can you please address the merge conflict? I think Ambassador may already have been added.

@danielbryantuk
Copy link
Contributor Author

Many thanks for the nudge @zparnold -- it looks like the PR adding Ambassador from @alexgervais that was just merged beat me to it (thanks Alex!) :-) #12348

I'm happy to close this PR

@zparnold
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@zparnold: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants