Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to install kubectl on Windows via scoop #12359

Merged
merged 4 commits into from
Feb 13, 2019
Merged

Add option to install kubectl on Windows via scoop #12359

merged 4 commits into from
Feb 13, 2019

Conversation

goostleek
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 24, 2019
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 24, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jan 24, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 5d36108

https://deploy-preview-12359--kubernetes-io-master-staging.netlify.com

Rajakavitha1
Rajakavitha1 suggested changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change: If you are on Windows and using Chocolatey package manager or scoop command-line installer, you can install kubectl with one of it.

To install kubectl on Windows you can use either Chocolatey package manager or scoop command-line installer.

@goostleek
Copy link
Contributor Author

Thx @Rajakavitha1, your suggestion is now applied.

@Rajakavitha1
Copy link
Contributor

I checked the preview on: https://deploy-preview-12359--kubernetes-io-master-staging.netlify.com/docs/tasks/tools/#install-kubectl

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 24, 2019
@Rajakavitha1
Copy link
Contributor

/assign @jimangel PTAL

@Rajakavitha1
Copy link
Contributor

/assign @jimangel

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 24, 2019
@goostleek goostleek force-pushed the patch-1 branch 2 times, most recently from 71b7428 to 5325c96 Compare January 24, 2019 13:53
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2019
@goostleek goostleek force-pushed the patch-1 branch 2 times, most recently from ef5fdcb to 5d36108 Compare January 24, 2019 14:18
@goostleek
Copy link
Contributor Author

goostleek commented Jan 24, 2019 •
edited
Loading

I had to remove the first item

  1. Run the installation command:

It seems the list numbering is not continued but restarted from 1 if the previous list item contains tabs. Take a look
image

Now it seems to look fine https://deploy-preview-12359--kubernetes-io-master-staging.netlify.com/docs/tasks/tools/install-kubectl/#install-on-windows-using-chocolatey-or-scoop. WDYT? Or maybe do you know the solution to continue the numbering?

@Rajakavitha1
Copy link
Contributor

Checked https://deploy-preview-12359--kubernetes-io-master-staging.netlify.com/docs/tasks/tools/install-kubectl/#install-on-windows-using-chocolatey-or-scoop. and it looks fine to me.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajakavitha1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit e7626d7 into kubernetes:master Feb 13, 2019
@goostleek goostleek deleted the patch-1 branch February 13, 2019 12:50
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@goostleek
Add option to install kubectl on Windows via scoop (kubernetes#12359)
6a5ec8b 
* Add option to install kubectl via scoop

* Review suggestions

* Fixed tab rendering

* Fixed list numbering
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@goostleek
Add option to install kubectl on Windows via scoop (kubernetes#12359)
3e95792 
* Add option to install kubectl via scoop

* Review suggestions

* Fixed tab rendering

* Fixed list numbering
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@goostleek @yagonobre
Add option to install kubectl on Windows via scoop (kubernetes#12359)
d3cb53b 
* Add option to install kubectl via scoop

* Review suggestions

* Fixed tab rendering

* Fixed list numbering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Rajakavitha1 requested changes

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@jimangel jimangel

@Rajakavitha1 Rajakavitha1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@goostleek @k8sio-netlify-preview-bot @Rajakavitha1 @k8s-ci-robot @jimangel