Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup to PR#10259 #10422

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Followup to PR#10259 #10422

merged 1 commit into from
Oct 4, 2018

Conversation

juanvallejo
Copy link
Contributor

Addresses typos and additional comments from review in #10259.

cc @soltysh @zparnold @kbhawkey

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 28, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit e9b22f0

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5bae4375dd28ef0f21c0eb92

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 28, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit e9b22f0

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5bae4375c9659239f1eaaade

soltysh
soltysh approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2018
@kbhawkey
Copy link
Contributor

kbhawkey commented Oct 1, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

@kbhawkey: changing LGTM is restricted to assignees, and only kubernetes/website repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zparnold
Copy link
Member

zparnold commented Oct 4, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2018
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 4, 2018
@k8s-ci-robot k8s-ci-robot merged commit 01677e2 into kubernetes:release-1.12 Oct 4, 2018
@juanvallejo juanvallejo deleted the jvallejo/followup-pr-10259 branch October 4, 2018 14:18
@juanvallejo juanvallejo mentioned this pull request Oct 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@juanvallejo @k8sio-netlify-preview-bot @kbhawkey @k8s-ci-robot @zparnold @soltysh @kubernetes-docs-i18n-bot