Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CSS height property to #oceanNodes main to fix spacing in Firefox #10169

Merged
merged 5 commits into from
Oct 15, 2018
Merged

Added CSS height property to #oceanNodes main to fix spacing in Firefox #10169

merged 5 commits into from
Oct 15, 2018

Conversation

alkaliphile
Copy link
Contributor

@alkaliphile alkaliphile commented Aug 31, 2018 •
edited
Loading

I added the height property to #oceanNodes main, only for tablet and desktop views. This makes the front page look consistent between Chrome and Firefox. Please see the before images for each browser, attached below.

Firefox:
image

Chrome:
image

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 31, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit ec937cd

https://deploy-preview-10169--kubernetes-io-master-staging.netlify.com

@alkaliphile
Copy link
Contributor Author

/assign @steveperry-53

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 31, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 94c1253

https://deploy-preview-10169--kubernetes-io-master-staging.netlify.com

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2018
@alkaliphile
Copy link
Contributor Author

/assign tengqm

@alkaliphile alkaliphile changed the title Changed CSS property for browser consistency. Added CSS height property to #oceanNodes main to fix spacing in Firefox Sep 8, 2018
@zparnold
Copy link
Member

zparnold commented Oct 4, 2018

@alkaliphile Can you please fix these merge conflicts?

@alkaliphile
Copy link
Contributor Author

@alkaliphile Can you please fix these merge conflicts?

@zparnold Sure! I'll take care of it this evening.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 5, 2018
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 5, 2018
@alkaliphile
Copy link
Contributor Author

@zparnold Done. I had to add the updated CSS property directly to styles.css. My original change to _tablet.sass didn't appear to work anymore, as the target in the JSON file at resources/_gen/assets/sass/sass is no longer the minified stylesheet.

@zparnold
Copy link
Member

zparnold commented Oct 5, 2018

@zacharysarah or @lucperkins Could you give me a quick sanity check on this one? I forgot how we were handling generated Sass?

@zacharysarah
Copy link
Contributor

@zparnold Thanks for checking! This looks sane to me, based on #10373, #10464, and the current contents of master.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit 49ee537 into kubernetes:master Oct 15, 2018
kbarnard10 pushed a commit that referenced this pull request Oct 16, 2018
Revert "Added CSS height property to #oceanNodes main to fix spacing …
a4e6abf 
…in Firefox (#10169)"

This reverts commit 49ee537.
k8s-ci-robot pushed a commit that referenced this pull request Oct 16, 2018
@k8s-ci-robot
Revert "Typo Fix" (#10624)
12732a6 
* Revert "Use CoCC email for reporting CoC violations (#10621)"

This reverts commit 612f9c2.

* Revert "Fix broken links for Korean tutorial pages (#10519)"

This reverts commit 9b4acdf.

* Revert "Added CSS height property to #oceanNodes main to fix spacing in Firefox (#10169)"

This reverts commit 49ee537.

* Revert "fix some typos (#10614)"

This reverts commit 98d2144.

* Revert "Typo Fix (#10620)"

This reverts commit 4a0f088.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@zacharysarah zacharysarah

@tengqm tengqm

@steveperry-53 steveperry-53

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@alkaliphile @k8sio-netlify-preview-bot @zparnold @zacharysarah @k8s-ci-robot @tengqm @steveperry-53 @kubernetes-docs-i18n-bot