Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh-cn][Umbrella] Remove or mark all references to k8s.gcr.io #39417

Closed
7 tasks done
mengjiao-liu opened this issue Feb 13, 2023 · 7 comments
Closed
7 tasks done

[zh-cn][Umbrella] Remove or mark all references to k8s.gcr.io #39417

mengjiao-liu opened this issue Feb 13, 2023 · 7 comments
Labels
language/zh Issues or PRs related to Chinese language triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mengjiao-liu
Copy link
Member

mengjiao-liu commented Feb 13, 2023

This issue is under the umbrella of #39353

for each downstream localization, find any mentions of k8s.gcr.io update to be level with the English version of pages

You can use the following command to find the file that still has content k8s.gcr.io and resync:

$ grep -r "k8s.gcr.io" ./content/zh-cn/*
$ ./scripts/lsync.sh <file>
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 13, 2023
@mengjiao-liu
Copy link
Member Author

/triage accepted
/language zh

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. language/zh Issues or PRs related to Chinese language and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 13, 2023
@mengjiao-liu
Copy link
Member Author

If anyone else wants to work here, please let me know so I can track it.

@devarsh10
Copy link

Hey @mengjiao-liu, I found some file which are still following k8s.gcr.io registry.
Can you guide me what should be my further steps?

Regards.

@mengjiao-liu
Copy link
Member Author

mengjiao-liu commented Feb 17, 2023

This is about the synchronization of Chinese content and I hope you didn't misread the synchronized language. @devarsh10

You may find the scripts/lsync.sh tool useful. For example, run the following command on the main branch:

./scripts/lsync.sh ./content/zh-cn/docs/reference/setup-tools/kubeadm/generated/kubeadm_init_phase_control-plane_scheduler.md

It will show you the changes to the upstream English source since the last time that page was sync'ed (or translated).Basically, those changes are the lines we need to resync to Chinese.

@devarsh10
Copy link

Okay. I may misread as I'm less aware of Chinese.
Thank you for the reply.
Regards

@mengjiao-liu
Copy link
Member Author

All tasks were done.
/close

@k8s-ci-robot
Copy link
Contributor

@mengjiao-liu: Closing this issue.

In response to this:

All tasks were done.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/zh Issues or PRs related to Chinese language triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants