Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotation service.kubernetes.io/topology-aware-hints not registered #36830

Closed
sftim opened this issue Sep 15, 2022 · 13 comments · Fixed by #38997
Closed

Annotation service.kubernetes.io/topology-aware-hints not registered #36830

sftim opened this issue Sep 15, 2022 · 13 comments · Fixed by #38997
Assignees
@sergeyshevch @Shivansh-yadav13
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/network Categorizes an issue or PR as relevant to SIG Network. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented Sep 15, 2022

This is a Bug Report

Problem:
Well-Known Labels, Annotations and Taints doesn't list the annotation
service.kubernetes.io/topology-aware-hints.

Proposed Solution:

Add service.kubernetes.io/topology-aware-hints to the Well-Known Labels, Annotations and Taints reference.

Page to Update:
https://kubernetes.io/docs/reference/labels-annotations-taints/

Additional Information:

See https://kubernetes.io/docs/concepts/services-networking/topology-aware-hints/ for details, and maybe put a link in the annotation reference that links there.

/language en
/sig network
@sftim sftim added the kind/bug Categorizes issue or PR as related to a bug. label Sep 15, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/network Categorizes an issue or PR as relevant to SIG Network. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 15, 2022
@sftim
Copy link
Contributor Author

sftim commented Sep 15, 2022

We should fix this before kubernetes/enhancements#2433 graduates to stable.

@Shivansh-yadav13
Copy link
Contributor

/assign

@sftim
Copy link
Contributor Author

sftim commented Sep 15, 2022

Anyone is welcome to contribute.

@sergeyshevch sergeyshevch mentioned this issue Sep 15, 2022
Merged
@mk46
Copy link
Member

mk46 commented Sep 16, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 16, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2022
@sergeyshevch
Copy link
Member

It looks like we resolved it in #36828

/close

@k8s-ci-robot
Copy link
Contributor

@sergeyshevch: Closing this issue.

In response to this:

It looks like we resolved it in #36828

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor Author

sftim commented Dec 18, 2022

Well-Known Labels, Annotations and Taints still doesn't list the annotation service.kubernetes.io/topology-aware-hints.

/reopen

@k8s-ci-robot
Copy link
Contributor

@sftim: Reopened this issue.

In response to this:

Well-Known Labels, Annotations and Taints still doesn't list the annotation service.kubernetes.io/topology-aware-hints.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Dec 18, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 17, 2023
@sergeyshevch
Copy link
Member

@sftim Thanks! I'd really missed that I didn't add it to this page.
Will create PR with the fix today

/assign

@sergeyshevch sergeyshevch mentioned this issue Jan 19, 2023
Merged
@sergeyshevch
Copy link
Member

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 20, 2023
@sftim
Copy link
Contributor Author

sftim commented Jan 20, 2023

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergeyshevch sergeyshevch

@Shivansh-yadav13 Shivansh-yadav13

Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/network Categorizes an issue or PR as relevant to SIG Network. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: service.kubernetes.io/topology-aware-hints sergeyshevch/website
6 participants
@sergeyshevch @k8s-ci-robot @sftim @mk46 @k8s-triage-robot @Shivansh-yadav13