-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Untidy prerequisites for “Set up Ingress on Minikube with the NGINX Ingress Controller” #20023
Comments
@sftim: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If you are looking to work on this and would like help, please reply here. I'll watch for replies. |
Isn't there an effort underway to move minikube related pages onto the minikube site? |
I can work on this one! Should I? |
I am looking to start contributing. looks like ..I can start with this. |
Go for it! Contributions welcome. Bear in mind https://www.redhat.com/en/blog/dont-lick-cookie when it comes to deciding if you want to work on this. @prasadkatti I think this example only happens to use Minikube; a separate PR could rework it to explain how to try out Ingress with a different kind of learning environment. |
@sftim I'm reviewing the content and looks like the tutorial is explaining how to deploy the Ingress Controller, which is exactly what the caution note is mentioning. IMHO, the caution node should be removed instead of moved to other section. |
@sftim another good point is that |
Sure, it's OK to remove the caution note. #20023 (comment) sounds like it could be a new separate issue(?) |
This is a Bug Report
Problem:
The page Set up Ingress on Minikube with the NGINX Ingress Controller has a cautionary note about a prerequisite:
this note belongs on the page, however the best place for it is in the Prerequisites section.
Proposed Solution:
Edit the page to move the caution note to be the very first thing inside the prerequisites section.
Page to Update:
https://kubernetes.io/docs/tasks/access-application-cluster/ingress-minikube/
/language en
/kind cleanup
/good-first-issue
The text was updated successfully, but these errors were encountered: