Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with k8s.io/docs/tasks/administer-cluster/kubeadm/kubeadm-certs/ #18169

Closed
leo-baltus opened this issue Dec 16, 2019 · 5 comments
Closed
Labels
sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@leo-baltus
Copy link

This is a Bug Report

Problem:
A cluster set-up using kubeadm needs a yearly certificate renewal procedure. This procedure consists of renewal of server certificates as well as client certificates. The client certificates renewal procedure is missing.

IMO after kubeadm alpha certs renew all either the client certificates in :
/etc/kubernetes/kubelet.conf, /etc/kubernetes/controller-manager.conf, /etc/kubernetes/scheduler.conf, /etc/kubernetes/admin.conf
should be renewed as well or the documentation should clearly suggest to renew clients certificates by doing:

cd /etc/kubernetes/
mv {admin.conf,controller-manager.conf,mv kubelet.conf,scheduler.conf} ~/
kubeadm init phase kubeconfig all

Proposed Solution:
I think that kubeadm alpha certs renew all should also update the client certificates.

Page to Update:
k8s.io/docs/tasks/administer-cluster/kubeadm/kubeadm-certs/

v1.13.10

@sftim
Copy link
Contributor

sftim commented Dec 16, 2019

/sig cluster-lifecycle
Looks valid, I'll let someone from SIG Cluster Lifecycle make a call on this.

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Dec 16, 2019
@neolit123
Copy link
Member

neolit123 commented Dec 16, 2019 via email

@leo-baltus
Copy link
Author

Upgraded step-by-step to v1.16.4. The client certificates seem all updated except /etc/kubernetes/kubelet.conf, which seems consistent with https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-certs/

So I changed /etc/kubernetes/kubelet.conf:

KUBECONFIG=/etc/kubernetes/kubelet.conf kubectl config set-cluster kubernetes --certificate-authority=/etc/kubernetes/pki/ca.crt
KUBECONFIG=/etc/kubernetes/kubelet.conf kubectl config set-credentials system:node:$HOSTNAME \
  --client-certificate=/var/lib/kubelet/pki/kubelet-client-current.pem \
  --client-key=/var/lib/kubelet/pki/kubelet-client-current.pem

So, this issue can be closed. Thanks.

@neolit123
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@neolit123: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Development

No branches or pull requests

4 participants