Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Recommendation Around Command Example in Doc Which Requires Root Privilege #17181

Closed
vanou opened this issue Oct 25, 2019 · 14 comments
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/docs Categorizes an issue or PR as relevant to SIG Docs.

Comments

@vanou
Copy link
Contributor

vanou commented Oct 25, 2019

This is a Bug Report

Problem:
In K8s doc, there are command examples which require root privilege. But there is inconsistency of use of sudo command in example (e.g. here&here with sudo but here without).

However there are pros&cons:

  • Command example with sudo
    • Pro:
      1. Clear indication where root privilege is required
    • Con:
      1. dependency on tool (sudo)
  • Command example without sudo
    • Pro:
      1. concise look of doc
      2. no dependency on tool
    • Con:
      1. reader who is relatively new to *nix should run commands with try&error
      2. addition of indication where root privilege is required to doc

Proposed Solution:
To add official recommendation around this to style guide.

Page to Update:
Too many pages, cannot specify here.

@aimeeu
Copy link
Contributor

aimeeu commented Oct 25, 2019

Thanks for creating an issue based on your #sig-docs question!

/kind feature
/sig docs
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/docs Categorizes an issue or PR as relevant to SIG Docs. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Oct 25, 2019
@sftim
Copy link
Contributor

sftim commented Oct 27, 2019

What do other projects do for this?

@neolit123
Copy link
Member

neolit123 commented Oct 27, 2019

i think the best option is to include notes in relevant locations that "these commands need to be run as root" and not have sudo in the examples.

@vanou
Copy link
Contributor Author

vanou commented Oct 28, 2019

In terms of code snippet, it's better to include sudo, because it can be used without any modification on CLI. However simple look of no sudo is also nice.

@vanou
Copy link
Contributor Author

vanou commented Oct 29, 2019

I think this problem is related to style guide. And according to Style guideline on this section, topics around style guide should be discussed at SIG Docs meeting.

I'll talk about this at next meeting.

@vishakhanihore
Copy link
Contributor

@vanou @aimeeu Can I work on this issue, if the issue has been already discussed in the meeting?

@vanou
Copy link
Contributor Author

vanou commented Dec 9, 2019

@vishakhanihore
Sorry. I haven't yet discussed it on meeting. However I'll do on next meeting (10th Dec).

And thanks for your interest.

@vanou
Copy link
Contributor Author

vanou commented Dec 11, 2019

I talked about this at today's meeting(2019/12/10). And I have a role to update Document Style Guide to add a guide around this issue. Discussion around this should be held at PR I'll create.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 10, 2020
@vanou
Copy link
Contributor Author

vanou commented Mar 12, 2020

@vishakhanihore Sorry. I don't have time to work on this issue. So, if possible, please take over this issue.

In brief, to tackle this issue

  1. Determine whether to use root or not in doc by yourself
  2. Claim your idea & discuss at community
  3. Make consensus
  4. Modify doc according to consensus

See meeting video at 2019/12/10 for what was discussed.

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 12, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 11, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 11, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

No branches or pull requests

7 participants