-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Recommendation Around Command Example in Doc Which Requires Root Privilege #17181
Comments
Thanks for creating an issue based on your #sig-docs question! /kind feature |
What do other projects do for this? |
i think the best option is to include notes in relevant locations that "these commands need to be run as root" and not have sudo in the examples. |
In terms of code snippet, it's better to include |
I think this problem is related to style guide. And according to Style guideline on this section, topics around style guide should be discussed at SIG Docs meeting. I'll talk about this at next meeting. |
@vishakhanihore And thanks for your interest. |
I talked about this at today's meeting(2019/12/10). And I have a role to update Document Style Guide to add a guide around this issue. Discussion around this should be held at PR I'll create. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@vishakhanihore Sorry. I don't have time to work on this issue. So, if possible, please take over this issue. In brief, to tackle this issue
See meeting video at 2019/12/10 for what was discussed. /remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a Bug Report
Problem:
In K8s doc, there are command examples which require root privilege. But there is inconsistency of use of
sudo
command in example (e.g. here&here with sudo but here without).However there are pros&cons:
sudo
sudo
)sudo
Proposed Solution:
To add official recommendation around this to style guide.
Page to Update:
Too many pages, cannot specify here.
The text was updated successfully, but these errors were encountered: