Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with k8s.io/docs/tutorials/kubernetes-basics/create-cluster/cluster-intro/ #17108

Closed
miteshskj opened this issue Oct 22, 2019 · 12 comments
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/docs Categorizes an issue or PR as relevant to SIG Docs.

Comments

@miteshskj
Copy link
Contributor

This is a Bug Report

Problem:
The feedback and create issue buttons on this page (and other pages under the k8s.io/docs/tutorials/kubernetes-basics section) are inconsistent with rest of the pages in documentation.

Page to Update:
Pages under - k8s.io/docs/tutorials/kubernetes-basics/

Screen shot of issue:
Small-text

Screen shot of text on other pages:
normal-text

@aimeeu
Copy link
Contributor

aimeeu commented Oct 23, 2019

/sig docs
/kind bug

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. kind/bug Categorizes issue or PR as related to a bug. labels Oct 23, 2019
@aimeeu
Copy link
Contributor

aimeeu commented Oct 23, 2019

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Oct 23, 2019
@kbhawkey
Copy link
Contributor

@miteshskj , right, I think I noted this in PR #17051.

  • The problem is that most of the tutorial pages link to styles.css, with settings that override a number of the k8s style values. The top nav bar is not correct, in addition to the problems already mentioned in this issue.
  • I did some testing, locally. Many of the settings, in styles.css, are not needed. I pared down this file and the tutorial pages clean up nicely, leaving the ks8/website style intact.
    @BenHall , did you by chance create the file, /content/en/docs/tutorials/kubernetes-basics/public/css/styles.css? I noticed that there are katacoda related vars in styles.css.

@BenHall
Copy link
Contributor

BenHall commented Oct 24, 2019

@kbhawkey Thanks for asking. I wasn't involved in this part. I believe it was directly ported over from another site to provide the quiz layout and also the reason why it's more verbose than required. It would be great to remove all the unrequired elements.

The katacoda css sections would still be required so that the sizing of the interactive elements are the same. Hopefully that will be easy to verify but please tag me in the PR so I can double check.

If you need me to do anything, please let me know.

@kbhawkey
Copy link
Contributor

/assign

@vishakhanihore
Copy link
Contributor

@BenHall Is the issue still open ?

@BenHall
Copy link
Contributor

BenHall commented Dec 9, 2019

@vishakhanihore I think it can be closed :)

@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 9, 2019

👍

@vishakhanihore
Copy link
Contributor

vishakhanihore commented Dec 9, 2019 via email

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 8, 2020
@vishakhanihore
Copy link
Contributor

vishakhanihore commented Mar 8, 2020 via email

@k8s-ci-robot
Copy link
Contributor

@vishakhanihore: Closing this issue.

In response to this:

/close

On Mon, 9 Mar, 2020, 02:14 fejta-bot, [email protected] wrote:

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually
close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta
https://github.com/fejta.
/lifecycle stale


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#17108,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AM6PS4RLT4LH5MSSMIGWCN3RGQGT7ANCNFSM4JDNOF4A
.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

No branches or pull requests

7 participants