Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with k8s.io/docs/reference/kubectl/conventions/ #16721

Closed
mkokabi opened this issue Oct 7, 2019 · 8 comments
Closed

Issue with k8s.io/docs/reference/kubectl/conventions/ #16721

mkokabi opened this issue Oct 7, 2019 · 8 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@mkokabi
Copy link

mkokabi commented Oct 7, 2019

This is a typo Report

Problem:
In this sentence:

To check the final resource that was created, use the --dry-run flag, which provides the object to be submitted to the cluster.

The word

provides

should be

prevents

Proposed Solution:

Page to Update:
https://kubernetes.io/docs/reference/kubectl/conventions/

@savitharaghunathan
Copy link
Member

IMO, I think the sentence needs to be rephrased. --dry-run flag provides the detailed definition of the object that would be created when the command is run, but at the same time it does not create an actual object.

/language en
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@savitharaghunathan:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

IMO, I think the sentence needs to be rephrased. --dry-run flag provides the detailed definition of the object that would be created when the command is run, but at the same time it does not create an actual object.

/language en
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 7, 2019
@sftim
Copy link
Contributor

sftim commented Oct 7, 2019

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Oct 7, 2019
@sshukun
Copy link
Contributor

sshukun commented Oct 8, 2019

Hi, I want to work on this

@sshukun
Copy link
Contributor

sshukun commented Oct 8, 2019

/assign

@vishakhanihore
Copy link
Contributor

Its good to be closed

@sftim
Copy link
Contributor

sftim commented Oct 8, 2019

/close
(fixed in #16732)

@k8s-ci-robot
Copy link
Contributor

@sftim: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

6 participants