cp env util from kubernetes/kubernetes #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor env into sub pkg
…rnetes into util-env
k8s-ci-robot
added
kind/cleanup
|
When this PR is merged, I will send a PR in k/k to update the vendor directory. |
|
/assign @apelisse |
|
And does #9 list all the pkgs that should be moved to utils repo ? I'd like to help to move them to here. |
|
/assign @thockin Tim, WDYT? of this new API |
apelisse
reviewed
Nov 3, 2020
thockin
reviewed
Nov 3, 2020
env/env.go
Outdated
|
|
||
| // GetEnvAsFloat64OrFallback returns the env variable (parsed as float64) for | ||
| // the given key and falls back to the given defaultValue if not set | ||
| func GetEnvAsFloat64OrFallback(key string, defaultValue float64) (float64, error) { |
There was a problem hiding this comment.
I would drop "64" - we're not going to add multiple flavors, I think. :)
pigletfly
force-pushed
the
util-env
branch
3 times, most recently
from
b42bde6 to
0a5333d
Compare
thockin
reviewed
Nov 4, 2020
thockin
reviewed
Nov 6, 2020
thockin
reviewed
Nov 10, 2020
|
Thanks! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pigletfly, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:
None