Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move perfdash over from contrib. #6582

Closed
wants to merge 3 commits into from
Closed

Conversation

porridge
Copy link
Member

@porridge porridge commented Feb 1, 2018

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: porridge
We suggest the following additional approver: cjwagner

Assign the PR to them by writing /assign @cjwagner in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 1, 2018
@porridge
Copy link
Member Author

porridge commented Feb 1, 2018

/cc @shyamjvs

@k8s-ci-robot k8s-ci-robot requested a review from shyamjvs February 1, 2018 09:30
@k8s-ci-robot
Copy link
Contributor

@porridge: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-test-infra-verify-bazel 10db292 link /test pull-test-infra-verify-bazel
pull-test-infra-verify-deps 10db292 link /test pull-test-infra-verify-deps
pull-test-infra-bazel 10db292 link /test pull-test-infra-bazel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@porridge
Copy link
Member Author

porridge commented Feb 1, 2018

Hints on how to deal with the failed tests (symlink loop and the superfluous dependencies) are most welcome. All I did after adding code was:

./hack/update-bazel.sh 
bazel build perfdash # failed
bazel run //:dep -- ensure
bazel build perfdash # failed
./hack/update-bazel.sh 
bazel build perfdash # success

@BenTheElder
Copy link
Member

hack/update-deps.sh would be good, your commands above aren't pruning vendor.

@porridge
Copy link
Member Author

porridge commented Feb 2, 2018

That ends with:

[...]
wrote "vendor/k8s.io/kubernetes/pkg/kubelet/apis/BUILD"
wrote "vendor/k8s.io/kubernetes/third_party/forked/etcd221/wal/BUILD"
+ hack/prune-libraries.sh --fix
ERROR: no such package 'vendor': error globbing [**]: /usr/local/google/home/porridge/projects/go/src/k8s.io/test-infra/vendor/github.com/coreos/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd/cmd/etcd (Too many levels of symbolic links)
++ echo FAILED
FAILED

@BenTheElder
Copy link
Member

@porridge this is etcd-io/etcd#8911

etcd has a ./cmd/etcd->../ symlink. I'm not sure how we should resolve this in the short term, but it looks like they're hoepfully amenable to removing this upstream.

@porridge
Copy link
Member Author

I don't have any good ideas for the short term, so closing this as the incompatibility is unlikely to be fixed by the time I leave the project.

@porridge porridge closed this Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants