Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Azure autoscaler 1.31 job #33437

Merged
merged 2 commits into from
Sep 6, 2024
Merged

add Azure autoscaler 1.31 job #33437

merged 2 commits into from
Sep 6, 2024

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Sep 6, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2024
@nojnhuh nojnhuh mentioned this pull request Sep 6, 2024
Merged
nojnhuh
nojnhuh commented Sep 6, 2024
View reviewed changes
config/jobs/kubernetes/sig-autoscaling/azure/cluster-autoscaler-azure-presubmits.yaml
Comment on lines -29 to -31
# This job is being phased out in favor of pull-cluster-autoscaler-e2e-azure-master. It always
# passes in order not to block PRs where the previous version of this job failed. This job can
# be removed when it is passing on all open PRs.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR now removes this old job and adds the 1.31 branch job. I split this into two commits to make that a little easier to follow.

Bryce-Soghigian
Bryce-Soghigian reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bryce-Soghigian, nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5f7f284 into kubernetes:master Sep 6, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@nojnhuh: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-autoscaler-azure-presubmits.yaml using file config/jobs/kubernetes/sig-autoscaling/azure/cluster-autoscaler-azure-presubmits.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nojnhuh nojnhuh deleted the azure-autoscaler-1.31 branch September 6, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bryce-Soghigian Bryce-Soghigian Bryce-Soghigian left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees

@Bryce-Soghigian Bryce-Soghigian

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nojnhuh @k8s-ci-robot @Bryce-Soghigian