Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imagevolume test focus #33088

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix imagevolume test focus #33088

merged 1 commit into from
Jul 24, 2024

Conversation

saschagrunert
Copy link
Member

It should prefix NodeFeature:, otherwise no tests will be run. The job config at least works per latest run in:

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/126220/pull-kubernetes-node-crio-cgrpv2-imagevolume-e2e/1816012535631974400

Follow-up on #33071

Will be required for kubernetes/kubernetes#126220

Asking for node approval @yujuhong @Random-Liu @dchen1107 @derekwaynecarr @sjenning @mrunalp @klueska @SergeyKanzhelev @endocrimes

cc @kubernetes/sig-node-cri-o-test-maintainers

@saschagrunert
Fix imagevolume test focus
32a777b 
It should prefix `NodeFeature:`, otherwise no tests will be run. The job
config at least works per latest run in:

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/126220/pull-kubernetes-node-crio-cgrpv2-imagevolume-e2e/1816012535631974400

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 24, 2024
This was referenced Jul 24, 2024
Open
Merged
@pacoxu
Copy link
Member

pacoxu commented Jul 24, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2024
endocrimes
endocrimes approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: endocrimes, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7220bfa into kubernetes:master Jul 24, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@saschagrunert: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

It should prefix NodeFeature:, otherwise no tests will be run. The job config at least works per latest run in:

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/126220/pull-kubernetes-node-crio-cgrpv2-imagevolume-e2e/1816012535631974400

Follow-up on #33071

Will be required for kubernetes/kubernetes#126220

Asking for node approval @yujuhong @Random-Liu @dchen1107 @derekwaynecarr @sjenning @mrunalp @klueska @SergeyKanzhelev @endocrimes

cc @kubernetes/sig-node-cri-o-test-maintainers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert saschagrunert deleted the image-volume-node-feature branch July 24, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@endocrimes endocrimes

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @pacoxu @k8s-ci-robot @endocrimes