Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd: add benchmark periodic jobs #32435

Merged

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Apr 11, 2024

Adds performance jobs for ratios:

Ratio Observed CPU usage Observed RAM usage Completion Time CPU request RAM request Configured Timeout
1/128 1.1 avg / 1.75 max 1 Gi avg / 3.2 Gi max 2 hrs 7 4 Gi 4 hrs
1/8 1.4 avg / 5 max 1 Gi avg / 4.9 Gi max 8 hrs 7 8 Gi 10 hrs
1/4 2.3 avg / 7 max 1.2 Gi avg / 5.4 Gi max 12 hrs 7 8 Gi 14 hrs
1/2 4.7 avg / 7 max 1.25 Gi avg / 6.3 Gi max 13 hrs 7 10 Gi 16 hrs
2/1 6.9 avg / 7 max 1.4Gi avg / 7.5 Gi max 14 hrs 7 10 Gi 16 hrs

Part of etcd-io/etcd#17754.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 11, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ivanvc!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @ivanvc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 11, 2024
@k8s-ci-robot k8s-ci-robot requested review from ahrtr and wenjiaswe April 11, 2024 20:57
@ivanvc
Copy link
Member Author

ivanvc commented Apr 11, 2024

@jmhbnz, can you please take a look at this?

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this @ivanvc - First thing is I think we can drop lazyfs from these jobs which will simplify a bit and improve security posture.

config/jobs/etcd/etcd-periodics.yaml Outdated Show resolved Hide resolved
config/jobs/etcd/etcd-periodics.yaml Outdated Show resolved Hide resolved
@ivanvc ivanvc force-pushed the add-etcd-periodics-benchmark-jobs branch from c199288 to c81464c Compare April 12, 2024 21:39
@ivanvc ivanvc marked this pull request as ready for review April 12, 2024 21:40
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2024
@ivanvc ivanvc requested a review from jmhbnz April 12, 2024 21:40
@k8s-ci-robot k8s-ci-robot requested a review from serathius April 12, 2024 21:40
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer now - thanks @ivanvc!

config/jobs/etcd/etcd-periodics.yaml Outdated Show resolved Hide resolved
config/jobs/etcd/etcd-periodics.yaml Show resolved Hide resolved
config/jobs/etcd/etcd-periodics.yaml Outdated Show resolved Hide resolved
config/jobs/etcd/etcd-periodics.yaml Show resolved Hide resolved
@ivanvc
Copy link
Member Author

ivanvc commented Apr 12, 2024

I'll redraft this. I will open it once I address the previous comments.

@ivanvc ivanvc marked this pull request as draft April 12, 2024 22:03
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2024
@ivanvc ivanvc force-pushed the add-etcd-periodics-benchmark-jobs branch from c81464c to bd967b8 Compare April 15, 2024 17:21
@ivanvc ivanvc marked this pull request as ready for review April 16, 2024 03:37
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2024
@ivanvc ivanvc requested a review from jmhbnz April 16, 2024 03:37
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ivanvc

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@ivanvc
Copy link
Member Author

ivanvc commented Apr 16, 2024

The tests failed because the jobs share the same testgrid-tab-name. I'll rename the tabs to match the job name.

@ivanvc ivanvc force-pushed the add-etcd-periodics-benchmark-jobs branch from bd967b8 to 9aaa995 Compare April 16, 2024 05:08
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2024
@ivanvc ivanvc requested a review from jmhbnz April 16, 2024 05:09
@ivanvc
Copy link
Member Author

ivanvc commented Apr 16, 2024

@jmhbnz, can you approve so tests can run again? Thanks.

@jmhbnz
Copy link
Member

jmhbnz commented Apr 16, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit 53ecf15 into kubernetes:master Apr 16, 2024
6 of 7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ivanvc: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-periodics.yaml using file config/jobs/etcd/etcd-periodics.yaml

In response to this:

Adds performance jobs for ratios:

Ratio Observed CPU usage Observed RAM usage Completion Time CPU request RAM request Configured Timeout
1/128 1.1 avg / 1.75 max 1 Gi avg / 3.2 Gi max 2 hrs 7 4 Gi 4 hrs
1/8 1.4 avg / 5 max 1 Gi avg / 4.9 Gi max 8 hrs 7 8 Gi 10 hrs
1/4 2.3 avg / 7 max 1.2 Gi avg / 5.4 Gi max 12 hrs 7 8 Gi 14 hrs
1/2 4.7 avg / 7 max 1.25 Gi avg / 6.3 Gi max 13 hrs 7 10 Gi 16 hrs
2/1 6.9 avg / 7 max 1.4Gi avg / 7.5 Gi max 14 hrs 7 10 Gi 16 hrs

Part of etcd-io/etcd#17754.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ivanvc ivanvc deleted the add-etcd-periodics-benchmark-jobs branch April 16, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants