Include PR's head Ref in ProwJob refs #29119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Mudrinić <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/prow
|
/assign petr-muller |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
This is unsafe, because prow tries to clone the ref, which is the branch name from the user's repo. Prow needs to be taught to ignore the ref or clone from their fork if we're include this info. Mitigating with a prow rollback first. https://kubernetes.slack.com/archives/C7J9RP96G/p1680020553428789 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes that we include PR's head ref (i.e. the branch that the PR was created from) in the ProwJob refs. We already have a field for that in the API, but we don't set that field at all. This PR ensures we set this field.
The use case for this is that some tools require the name of the head branch to work properly.
/assign @cblecker @cjwagner @stevekuznetsov