Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller-runtime: change jobs to main #28742

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Feb 14, 2023

xref: kubernetes-sigs/controller-runtime#1026

This PR should cover the following sub-tasks from the issue and be non-disruptive:

  • If a presubmit or postsubmit prowjob triggers on the master branch (branches field of the prowjob), add the main branch to the list
  • For periodic prowjobs, or any prowjob that mentions the master branch in base_ref, update them to the main branch.
    • I just added a new job for main. The old one for master will be removed after the branch rename in the CR repo
  • If a prowjob mentions master in its name, rename the job to not include the branch name

After this PR we should be ready to actually rename the branch in the repo according to the official instructions.

@sbueringer
Copy link
Member Author

/hold
As I set a lazy consensus deadline until end of this week in the mail: https://groups.google.com/g/kubernetes-sig-api-machinery/c/KfSVRcA_JC4

/assign @alvaroaleman @vincepri

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 14, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2023
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit f690cf5 into kubernetes:master Feb 16, 2023
@k8s-ci-robot
Copy link
Contributor

@sbueringer: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key controller-runtime-periodics-master.yaml using file ``
  • key controller-runtime-periodics-main.yaml using file config/jobs/kubernetes-sigs/controller-runtime/controller-runtime-periodics-main.yaml
  • key controller-runtime-presubmits-master.yaml using file ``
  • key controller-runtime-presubmits-main.yaml using file config/jobs/kubernetes-sigs/controller-runtime/controller-runtime-presubmits-main.yaml

In response to this:

xref: kubernetes-sigs/controller-runtime#1026

This PR should cover the following sub-tasks from the issue and be non-disruptive:

  • If a presubmit or postsubmit prowjob triggers on the master branch (branches field of the prowjob), add the main branch to the list
  • For periodic prowjobs, or any prowjob that mentions the master branch in base_ref, update them to the main branch.
  • I just added a new job for main. The old one for master will be removed after the branch rename in the CR repo
  • If a prowjob mentions master in its name, rename the job to not include the branch name

After this PR we should be ready to actually rename the branch in the repo according to the official instructions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-cr-main branch February 16, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants