Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a periodic CI job to test the Evented PLEG feature #28592

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Add a periodic CI job to test the Evented PLEG feature #28592

merged 1 commit into from
Feb 2, 2023

Conversation

sairameshv
Copy link
Member

Periodic job runs the Node e2e tests by enabling the evented-pleg feature.

Signed-off-by: Sai Ramesh Vanka [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config labels Jan 31, 2023
@k8s-ci-robot k8s-ci-robot added area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sairameshv. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2023
@sairameshv
Copy link
Member Author

/cc @harche @mrunalp

@harche
Copy link
Contributor

harche commented Jan 31, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Jan 31, 2023

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jan 31, 2023
@sairameshv
Copy link
Member Author

sairameshv commented Jan 31, 2023 •
edited
Loading

/hold until a pre-submit job successfully runs without any issue.

Presubmit Job Link: https://testgrid.k8s.io/sig-node-presubmits#pr-crio-cgrpv1-evented-pleg-gce-e2e

Possible Fix for the pre-submit job to run without the Permission Denied issue.
#28596

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2023
@harche
Copy link
Contributor

harche commented Feb 1, 2023

/hold until a pre-submit job successfully runs without any issue.

Presubmit Job Link: https://testgrid.k8s.io/sig-node-presubmits#pr-crio-cgrpv1-evented-pleg-gce-e2e

Possible Fix for the pre-submit job to run without the Permission Denied issue. #28596

@sairameshv The job is passing. I think the hold can be removed now.

SergeyKanzhelev
SergeyKanzhelev reviewed Feb 1, 2023
View reviewed changes
config/jobs/kubernetes/sig-node/crio.yaml Outdated
- name: GOPATH
value: /go
annotations:
testgrid-dashboards: sig-node-cri-o, sig-release-master-informing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove sig-release-master-informing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree that this job can be monitored in the sig-node-cri-o dashboard alone as of now.

@SergeyKanzhelev
Copy link
Member

/retest
/unhold
/triage accepted

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2023
@sairameshv sairameshv changed the title OCPNODE-1417: Add a periodic CI job to test the Evented PLEG feature Add a periodic CI job to test the Evented PLEG feature Feb 2, 2023
@sairameshv
Add a periodic CI job to test the Evented PLEG feature
bcfdc89 
This periodic job runs the e2e node conformance tests by enabling the
evented pleg feature both at Kubelet and crio

Signed-off-by: Sai Ramesh Vanka [email protected]
@harche
Copy link
Contributor

harche commented Feb 2, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, sairameshv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1041a2b into kubernetes:master Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

@sairameshv: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key crio.yaml using file config/jobs/kubernetes/sig-node/crio.yaml

In response to this:

Periodic job runs the Node e2e tests by enabling the evented-pleg feature.

Signed-off-by: Sai Ramesh Vanka [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sairameshv sairameshv mentioned this pull request Feb 8, 2023
Closed
9 tasks
@pacoxu pacoxu mentioned this pull request Jan 12, 2024
Open
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@mrunalp mrunalp mrunalp approved these changes

@bobbypage bobbypage Awaiting requested review from bobbypage

@endocrimes endocrimes Awaiting requested review from endocrimes

@harche harche Awaiting requested review from harche

Assignees

@mrunalp mrunalp

@harche harche

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sairameshv @k8s-ci-robot @harche @bart0sh @SergeyKanzhelev @mrunalp