config-forker: perform replacement on Command for presubmits and postsubmits #28097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We started performing replacement on Command for periodics in kubernetes#28090. However, we did it only for periodics and I think that we should do it for presubmits and postsubmits to have the consistent behavior. This commit also adds tests for the command replacements. Signed-off-by: Marko Mudrinić <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/release-eng
cpanato
reviewed
Nov 23, 2022
k8s-ci-robot
added
the
lgtm
justaugustus
approved these changes
Nov 23, 2022
|
/retest |
saschagrunert
approved these changes
Nov 23, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the conversation in https://kubernetes.slack.com/archives/CJH2GBF7Y/p1669065861073859, kubernetes/sig-release#850:
We started performing replacement on Command for periodics in #28090. However, we did it only for periodics and I think that we should do it for presubmits and postsubmits to have consistent behavior.
This commit also adds tests for the command replacements.
/assign @justaugustus @jeremyrickard @cici37
cc: @kubernetes/release-engineering