Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add build-dir for ingress-nginx job to allow shared variable #26922

Merged
merged 1 commit into from
Jul 26, 2022
Merged

fix: add build-dir for ingress-nginx job to allow shared variable #26922

merged 1 commit into from
Jul 26, 2022

Conversation

tao12345666333
Copy link
Member

Signed-off-by: Jintao Zhang [email protected]

/cc @rikatz @strongjz

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2022
@longwuyuan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 26, 2022
@strongjz
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2022
@dims
Copy link
Member

dims commented Jul 26, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3baf8cc into kubernetes:master Jul 26, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 26, 2022
@k8s-ci-robot
Copy link
Contributor

@tao12345666333: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-ingress-nginx.yaml using file config/jobs/image-pushing/k8s-staging-ingress-nginx.yaml

In response to this:

Signed-off-by: Jintao Zhang [email protected]

/cc @rikatz @strongjz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tao12345666333 tao12345666333 mentioned this pull request Jul 26, 2022
Merged
@tao12345666333 tao12345666333 deleted the fix-ingress-nginx-build-dir branch July 26, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikatz rikatz Awaiting requested review from rikatz

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@strongjz strongjz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@tao12345666333 @longwuyuan @strongjz @dims @k8s-ci-robot